| Message ID | 1454509468-10627-1-git-send-email-joonas.lahtinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Joonas, On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote: > Use distinctive name for cpu_hotplug.dep_map to avoid the actual > cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats. > > Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > --- > kernel/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 5b9d396..6a13f24 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -78,7 +78,7 @@ static struct { > .wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq), > .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), > #ifdef CONFIG_DEBUG_LOCK_ALLOC > - .dep_map = {.name = "cpu_hotplug.lock" }, > + .dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", &cpu_hotplug.dep_map), Looks good to me! Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> -- Thanks and Regards gautham.
Hi, According to scripts/get_maintainer.pl Ingo or Peter would be more appropriate to merge. Added them as To: On ke, 2016-02-03 at 22:42 +0530, Gautham R Shenoy wrote: > Hello Joonas, > > On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote: > > Use distinctive name for cpu_hotplug.dep_map to avoid the actual > > cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats. > > > > Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Cc: Intel graphics driver community testing & development <intel-gf > > x@lists.freedesktop.org> > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > --- > > kernel/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/cpu.c b/kernel/cpu.c > > index 5b9d396..6a13f24 100644 > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -78,7 +78,7 @@ static struct { > > .wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq), > > .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > > - .dep_map = {.name = "cpu_hotplug.lock" }, > > + .dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", > > &cpu_hotplug.dep_map), > > Looks good to me! > Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > Thanks! Regards, Joonas > -- > Thanks and Regards > gautham. >
diff --git a/kernel/cpu.c b/kernel/cpu.c index 5b9d396..6a13f24 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -78,7 +78,7 @@ static struct { .wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq), .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), #ifdef CONFIG_DEBUG_LOCK_ALLOC - .dep_map = {.name = "cpu_hotplug.lock" }, + .dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", &cpu_hotplug.dep_map), #endif };
Use distinctive name for cpu_hotplug.dep_map to avoid the actual cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats. Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: Intel graphics driver community testing & development <intel-gfx@lists.freedesktop.org> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> --- kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)