| Message ID | 1457146252-4577-2-git-send-email-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 04, 2016 at 08:50:38PM -0600, Pierre-Louis Bossart wrote: > Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT > are inverted. Not according to the docs. Are the docs wrong? > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 71abf57..228b22f 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2029,8 +2029,8 @@ enum skl_disp_power_wells { > > #define I915_PM_INTERRUPT (1<<31) > #define I915_ISP_INTERRUPT (1<<22) > -#define I915_LPE_PIPE_B_INTERRUPT (1<<21) > -#define I915_LPE_PIPE_A_INTERRUPT (1<<20) > +#define I915_LPE_PIPE_A_INTERRUPT (1<<21) > +#define I915_LPE_PIPE_B_INTERRUPT (1<<20) > #define I915_MIPIC_INTERRUPT (1<<19) > #define I915_MIPIA_INTERRUPT (1<<18) > #define I915_PIPE_CONTROL_NOTIFY_INTERRUPT (1<<18) > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 3/5/16 7:27 AM, Ville Syrjälä wrote: > On Fri, Mar 04, 2016 at 08:50:38PM -0600, Pierre-Louis Bossart wrote: >> Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT >> are inverted. > > Not according to the docs. Are the docs wrong? Possibly. I compared with the Android code and flagged this conflict, I didn't dig deeper.
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 71abf57..228b22f 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -2029,8 +2029,8 @@ enum skl_disp_power_wells { #define I915_PM_INTERRUPT (1<<31) #define I915_ISP_INTERRUPT (1<<22) -#define I915_LPE_PIPE_B_INTERRUPT (1<<21) -#define I915_LPE_PIPE_A_INTERRUPT (1<<20) +#define I915_LPE_PIPE_A_INTERRUPT (1<<21) +#define I915_LPE_PIPE_B_INTERRUPT (1<<20) #define I915_MIPIC_INTERRUPT (1<<19) #define I915_MIPIA_INTERRUPT (1<<18) #define I915_PIPE_CONTROL_NOTIFY_INTERRUPT (1<<18)
Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT are inverted. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)