diff mbox

[v2] libdrm/fourcc: Add formats R8, RG88, GR88, NV24, NV42

Message ID 1461260779-26455-1-git-send-email-dongseong.hwang@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hwang, Dongseong April 21, 2016, 5:46 p.m. UTC 
Produced from headers_install of 9dabb0053b63bc32ab6ad5d13209d1e43395313f
(drm-intel-nightly) in the kernel.

ChromeOS will use new format to optimize video decoding.

CC: Stéphane Marchesin <marcheu@chromium.org>
CC: Daniele Castagna <dcastagna@chromium.org>
CC: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Rainer Hochecker <rainer.hochecker@onlinehome.de>
Cc: Benjamin Widawsky <benjamin.widawsky@intel.com>
CC: Chad Versace <chad.versace@intel.com>
Signed-off-by: Dongseong Hwang <dongseong.hwang@intel.com>
---
 include/drm/drm_fourcc.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Emil Velikov April 21, 2016, 5:56 p.m. UTC | #1 
On 21 April 2016 at 18:46, Dongseong Hwang <dongseong.hwang@intel.com> wrote:
> Produced from headers_install of 9dabb0053b63bc32ab6ad5d13209d1e43395313f
> (drm-intel-nightly) in the kernel.
>
> ChromeOS will use new format to optimize video decoding.
>
Did you check before sending the patch out ?
As mentioned over IRC a few times - there's no need for the
update.danvet already sorted it out.

Also, I realise that CrOS development is quite high paced, although
some of us prefer quality over quantity. Meaning: don't send multiple
emails (spam?) if you have not covered (ideally) all the concerns
mentioned. Not doing so is one of the ways to alienate developers.

Pretty please ?

Thanks
Emil
diff mbox

Patch

diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index e741b09..bf68099 100644
--- a/include/drm/drm_fourcc.h
+++ b/include/drm/drm_fourcc.h
@@ -34,6 +34,13 @@ 
 /* color index */
 #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
 
+/* 8 bpp Red */
+#define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
+
+/* 16 bpp RG */
+#define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
+#define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
@@ -106,6 +113,8 @@ 
 #define DRM_FORMAT_NV21		fourcc_code('N', 'V', '2', '1') /* 2x2 subsampled Cb:Cr plane */
 #define DRM_FORMAT_NV16		fourcc_code('N', 'V', '1', '6') /* 2x1 subsampled Cr:Cb plane */
 #define DRM_FORMAT_NV61		fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */
+#define DRM_FORMAT_NV24		fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */
+#define DRM_FORMAT_NV42		fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */
 
 /*
  * 3 plane YCbCr
@@ -216,7 +225,7 @@ 
  * - multiple of 128 pixels for the width
  * - multiple of  32 pixels for the height
  *
- * For more information: see http://linuxtv.org/downloads/v4l-dvb-apis/re32.html
+ * For more information: see https://linuxtv.org/downloads/v4l-dvb-apis/re32.html
  */
 #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)