diff mbox

kms_atomic: Fix crtc_id comparison failing.

Message ID 1461291868-10530-1-git-send-email-robert.foss@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Foss April 22, 2016, 2:24 a.m. UTC
From: Robert Foss <robert.foss@collabora.com>

Fixed ctrc_id comparison failing due to bad initialization of
crtc variable.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
 tests/kms_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marius Vlad April 22, 2016, 9:54 a.m. UTC | #1
You've already sent this yesterday. Its pushed.

On Thu, Apr 21, 2016 at 10:24:28PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
> 
> Fixed ctrc_id comparison failing due to bad initialization of
> crtc variable.
> 
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
>  tests/kms_atomic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index 13a5db1..f27ee46 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -1361,7 +1361,7 @@ igt_main
>  
>  	igt_subtest("atomic_invalid_params") {
>  		struct kms_atomic_state *scratch = atomic_state_dup(current);
> -		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
> +		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
>  		struct kms_atomic_plane_state *plane =
>  			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
>  		struct kms_atomic_connector_state *conn =
> -- 
> 2.5.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter April 22, 2016, 1 p.m. UTC | #2
On Fri, Apr 22, 2016 at 12:54:59PM +0300, Marius Vlad wrote:
> You've already sent this yesterday. Its pushed.

When you push patches (especially from other people), please send out a
quick confirmation mail to the mailing list. Avoids confusion like this
one here.
-Daniel

> 
> On Thu, Apr 21, 2016 at 10:24:28PM -0400, robert.foss@collabora.com wrote:
> > From: Robert Foss <robert.foss@collabora.com>
> > 
> > Fixed ctrc_id comparison failing due to bad initialization of
> > crtc variable.
> > 
> > Signed-off-by: Robert Foss <robert.foss@collabora.com>
> > ---
> >  tests/kms_atomic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> > index 13a5db1..f27ee46 100644
> > --- a/tests/kms_atomic.c
> > +++ b/tests/kms_atomic.c
> > @@ -1361,7 +1361,7 @@ igt_main
> >  
> >  	igt_subtest("atomic_invalid_params") {
> >  		struct kms_atomic_state *scratch = atomic_state_dup(current);
> > -		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
> > +		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
> >  		struct kms_atomic_plane_state *plane =
> >  			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
> >  		struct kms_atomic_connector_state *conn =
> > -- 
> > 2.5.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx



> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 13a5db1..f27ee46 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -1361,7 +1361,7 @@  igt_main
 
 	igt_subtest("atomic_invalid_params") {
 		struct kms_atomic_state *scratch = atomic_state_dup(current);
-		struct kms_atomic_crtc_state *crtc = &scratch->crtcs[0];
+		struct kms_atomic_crtc_state *crtc = find_crtc(scratch, true);
 		struct kms_atomic_plane_state *plane =
 			find_plane(scratch, NUM_PLANE_TYPE_PROPS, crtc);
 		struct kms_atomic_connector_state *conn =