Message ID | 1461805865-212590-8-git-send-email-tom.orourke@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Apr 27, 2016 at 06:10:51PM -0700, tom.orourke@intel.com wrote: > From: Tom O'Rourke <Tom.O'Rourke@intel.com> > > When frequency requests are made by SLPC, host driver > should not attempt to make frequency requests due to > potential conflicts. > > Host-based turbo operations are already avoided when > SLPC is used. This change covers other frequency > requests such as from sysfs or debugfs interfaces. > > A later patch in this series updates sysfs/debugfs > interfaces for setting max/min frequencies with SLPC. Since under your scheme, this function is only called from those user interfaces, why haven't you implemented it here? As the intel_set_* it is meant to providing the uniform API supporting as many generation as possible, without having to spread that knowledge around. You have not explained the API change. -Chris
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 35d7f19..f480551 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -4581,6 +4581,9 @@ void gen6_rps_boost(struct drm_i915_private *dev_priv, void intel_set_rps(struct drm_device *dev, u8 val) { + if (intel_slpc_active(dev)) + return; + if (IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)) valleyview_set_rps(dev, val); else