diff mbox

[i-g-t,v5,6/6] kms_panel_fitting: Enable connectors with "scaling mode" property set.

Message ID 1461851124-27256-7-git-send-email-robert.foss@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Foss April 28, 2016, 1:45 p.m. UTC
From: Robert Foss <robert.foss@collabora.com>

Enable testing on all connectors that have the "scaling mode"
property set.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012
Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 tests/kms_panel_fitting.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Comments

Marius Vlad May 3, 2016, 1:31 p.m. UTC | #1
This doesn't apply cleanly, the patch from Jani from was not applied, so
is still using igt_require() for testing the connector type. Diff
against master.

On Thu, Apr 28, 2016 at 09:45:24AM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
> 
> Enable testing on all connectors that have the "scaling mode"
> property set.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/kms_panel_fitting.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 272a531..b796c68 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -139,9 +139,18 @@ static void test_panel_fitting(data_t *d)
>  
>  	for_each_connected_output(display, output) {
>  		drmModeModeInfo *mode, native_mode;
> -
> -		if (output->config.connector->connector_type !=
> -		    DRM_MODE_CONNECTOR_eDP)
> +		bool scaling_mode_set;
> +
> +		scaling_mode_set = kmstest_get_property(d->drm_fd,
> +			output->config.connector->connector_id,
> +			DRM_MODE_OBJECT_CONNECTOR,
> +			"scaling mode",
> +			NULL,
> +			NULL,
> +			NULL);
> +
> +		/* Check that the "scaling mode" property has been set. */
> +		if (!scaling_mode_set)
>  			continue;
>  
>  		pipe = output->config.pipe;
> -- 
> 2.5.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 272a531..b796c68 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -139,9 +139,18 @@  static void test_panel_fitting(data_t *d)
 
 	for_each_connected_output(display, output) {
 		drmModeModeInfo *mode, native_mode;
-
-		if (output->config.connector->connector_type !=
-		    DRM_MODE_CONNECTOR_eDP)
+		bool scaling_mode_set;
+
+		scaling_mode_set = kmstest_get_property(d->drm_fd,
+			output->config.connector->connector_id,
+			DRM_MODE_OBJECT_CONNECTOR,
+			"scaling mode",
+			NULL,
+			NULL,
+			NULL);
+
+		/* Check that the "scaling mode" property has been set. */
+		if (!scaling_mode_set)
 			continue;
 
 		pipe = output->config.pipe;