Message ID | 1464597519-16659-5-git-send-email-chris@chris-wilson.co.uk (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, May 30, 2016 at 09:38:22AM +0100, Chris Wilson wrote: > As we now can call drm_connector_unregister() multiple times, provide a > failsafe unregister for a connector when cleaning it up. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Maybe WARN_ON(connector->registered); or is that way too noisy? -Daniel > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 8b9ee921a9e1..ba6689ba0ad9 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -984,6 +984,8 @@ void drm_connector_cleanup(struct drm_connector *connector) > struct drm_device *dev = connector->dev; > struct drm_display_mode *mode, *t; > > + drm_connector_unregister(connector); > + > if (connector->tile_group) { > drm_mode_put_tile_group(dev, connector->tile_group); > connector->tile_group = NULL; > -- > 2.8.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 8b9ee921a9e1..ba6689ba0ad9 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -984,6 +984,8 @@ void drm_connector_cleanup(struct drm_connector *connector) struct drm_device *dev = connector->dev; struct drm_display_mode *mode, *t; + drm_connector_unregister(connector); + if (connector->tile_group) { drm_mode_put_tile_group(dev, connector->tile_group); connector->tile_group = NULL;
As we now can call drm_connector_unregister() multiple times, provide a failsafe unregister for a connector when cleaning it up. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_crtc.c | 2 ++ 1 file changed, 2 insertions(+)