| Message ID | 1464765021-16206-2-git-send-email-chix.ding@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
General comment (that applies to the whole series); when you write your commit message, the first line (which becomes the email subject above) should be prefixed by "drm/i915:" If your patch is only modifying the code for a specific platform, you can include that too when appropriate (e.g., "drm/i915/skl:"). On Wed, Jun 01, 2016 at 08:10:17AM +0100, chix.ding@intel.com wrote: > From: Chi Ding <chix.ding@intel.com> > > Everything except fifo_size is unused and therefore removed > > This is the first patch of two-level watermark for VLV/CHV I think you can leave this line out of your description. Killing off dead code / unused fields is worthwhile on its own and doesn't really need two-level watermarks as justification. With an updated commit message, Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > > v2: Split the first patch of v1 into the following patches > - Remove unused parameters from intel_plane_wm_parameters. > - Rename skl_plane_id to wm_plane_id. > - Move fifo_size from intel_plane_wm_parameters to vlv_wm_state. > > Signed-off-by: Chi Ding <chix.ding@intel.com> > > cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > cc: matthew.d.roper@intel.com > cc: yetundex.adebisi@intel.com > > --- > drivers/gpu/drm/i915/intel_drv.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 9b5f663..b973b86 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -697,21 +697,6 @@ struct intel_crtc { > }; > > struct intel_plane_wm_parameters { > - uint32_t horiz_pixels; > - uint32_t vert_pixels; > - /* > - * For packed pixel formats: > - * bytes_per_pixel - holds bytes per pixel > - * For planar pixel formats: > - * bytes_per_pixel - holds bytes per pixel for uv-plane > - * y_bytes_per_pixel - holds bytes per pixel for y-plane > - */ > - uint8_t bytes_per_pixel; > - uint8_t y_bytes_per_pixel; > - bool enabled; > - bool scaled; > - u64 tiling; > - unsigned int rotation; > uint16_t fifo_size; > }; > > -- > 1.8.0.1 >
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 9b5f663..b973b86 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -697,21 +697,6 @@ struct intel_crtc { }; struct intel_plane_wm_parameters { - uint32_t horiz_pixels; - uint32_t vert_pixels; - /* - * For packed pixel formats: - * bytes_per_pixel - holds bytes per pixel - * For planar pixel formats: - * bytes_per_pixel - holds bytes per pixel for uv-plane - * y_bytes_per_pixel - holds bytes per pixel for y-plane - */ - uint8_t bytes_per_pixel; - uint8_t y_bytes_per_pixel; - bool enabled; - bool scaled; - u64 tiling; - unsigned int rotation; uint16_t fifo_size; };