| Message ID | 1465993109-19523-31-git-send-email-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15/06/16 13:18, Chris Wilson wrote: > Don't emit a driver DRM_ERROR for a user passing in an invalid CRTC id, > simply report it is missing back to the user. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/intel_display.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 67adf990adb5..74a6d70ce912 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -14551,11 +14551,8 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data, > struct intel_crtc *crtc; > > drmmode_crtc = drm_crtc_find(dev, pipe_from_crtc_id->crtc_id); > - > - if (!drmmode_crtc) { > - DRM_ERROR("no such CRTC id\n"); > + if (!drmmode_crtc) > return -ENOENT; > - } > > crtc = to_intel_crtc(drmmode_crtc); > pipe_from_crtc_id->pipe = crtc->pipe; > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 67adf990adb5..74a6d70ce912 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -14551,11 +14551,8 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data, struct intel_crtc *crtc; drmmode_crtc = drm_crtc_find(dev, pipe_from_crtc_id->crtc_id); - - if (!drmmode_crtc) { - DRM_ERROR("no such CRTC id\n"); + if (!drmmode_crtc) return -ENOENT; - } crtc = to_intel_crtc(drmmode_crtc); pipe_from_crtc_id->pipe = crtc->pipe;
Don't emit a driver DRM_ERROR for a user passing in an invalid CRTC id, simply report it is missing back to the user. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_display.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)