| Message ID | 1466718636-19675-2-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ > - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ > - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ > - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
On Fri, 24 Jun 2016, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurations overview > section of BSpec. > > So it is better removing them before they become used in any > other future platform. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Please reply to the list when you actually push. Both of these could have used cc: drm-intel-fixes because we support kbl starting v4.7. I've picked them to fixes now. BR, Jani. > --- > include/drm/i915_pciids.h | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 87dde1c..33466bf 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -325,15 +325,10 @@ > #define INTEL_KBL_GT3_IDS(info) \ > INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \ > INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \ > - INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \ > - INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \ > - INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */ > + INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */ > > #define INTEL_KBL_GT4_IDS(info) \ > - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ > - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ > - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ > - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 */ > + INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */ > > #define INTEL_KBL_IDS(info) \ > INTEL_KBL_GT1_IDS(info), \
On Wed, 2016-06-29 at 12:24 +0300, Jani Nikula wrote: > On Fri, 24 Jun 2016, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > > > This is unusual. Usually IDs listed on early stages of platform > > definition are kept there as reserved for later use. > > > > However these IDs here are not listed anymore in any of steppings > > and devices IDs tables for Kabylake on configurations overview > > section of BSpec. > > > > So it is better removing them before they become used in any > > other future platform. > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Please reply to the list when you actually push. ops. I merged yesterday but forgot to reply, sorry. > > Both of these could have used cc: drm-intel-fixes because we support > kbl > starting v4.7. I've picked them to fixes now. Thanks > > BR, > Jani. > > > > > --- > > include/drm/i915_pciids.h | 9 ++------- > > 1 file changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index 87dde1c..33466bf 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -325,15 +325,10 @@ > > #define INTEL_KBL_GT3_IDS(info) \ > > INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \ > > INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \ > > - INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \ > > - INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \ > > - INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */ > > + INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */ > > > > #define INTEL_KBL_GT4_IDS(info) \ > > - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ > > - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ > > - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ > > - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 */ > > + INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */ > > > > #define INTEL_KBL_IDS(info) \ > > INTEL_KBL_GT1_IDS(info), \
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 87dde1c..33466bf 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -325,15 +325,10 @@ #define INTEL_KBL_GT3_IDS(info) \ INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \ INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \ - INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \ - INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \ - INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */ + INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */ #define INTEL_KBL_GT4_IDS(info) \ - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 */ + INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */ #define INTEL_KBL_IDS(info) \ INTEL_KBL_GT1_IDS(info), \
This is unusual. Usually IDs listed on early stages of platform definition are kept there as reserved for later use. However these IDs here are not listed anymore in any of steppings and devices IDs tables for Kabylake on configurations overview section of BSpec. So it is better removing them before they become used in any other future platform. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- include/drm/i915_pciids.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)