| Message ID | 1466718645-19814-2-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurations overview > section of BSpec. > > So it is better removing them before they become used in any > other future platform. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > lib/intel_chipset.h | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h > index 1c894d5..3967468 100644 > --- a/lib/intel_chipset.h > +++ b/lib/intel_chipset.h > @@ -223,18 +223,13 @@ void intel_check_pch(void); > #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912 > #define PCI_CHIP_KABYLAKE_DT_GT1_5 0x5917 > #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902 > -#define PCI_CHIP_KABYLAKE_DT_GT4 0x5932 > #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B > -#define PCI_CHIP_KABYLAKE_HALO_GT3 0x592B > #define PCI_CHIP_KABYLAKE_H_GT1_0 0x5908 > #define PCI_CHIP_KABYLAKE_H_GT1_1 0x590B > #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B > #define PCI_CHIP_KABYLAKE_SRV_GT2 0x591A > -#define PCI_CHIP_KABYLAKE_SRV_GT3 0x592A > -#define PCI_CHIP_KABYLAKE_SRV_GT4 0x593A > #define PCI_CHIP_KABYLAKE_SRV_GT1 0x590A > #define PCI_CHIP_KABYLAKE_WKS_GT2 0x591D > -#define PCI_CHIP_KABYLAKE_WKS_GT4 0x593D > > #define PCI_CHIP_BROXTON_0 0x0A84 > #define PCI_CHIP_BROXTON_1 0x1A84 > @@ -447,14 +442,9 @@ void intel_check_pch(void); > > #define IS_KBL_GT3(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0|| \ > (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1|| \ > - (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2|| \ > - (devid) == PCI_CHIP_KABYLAKE_HALO_GT3|| \ > - (devid) == PCI_CHIP_KABYLAKE_SRV_GT3) > - > -#define IS_KBL_GT4(devid) ((devid) == PCI_CHIP_KABYLAKE_DT_GT4|| \ > - (devid) == PCI_CHIP_KABYLAKE_HALO_GT4|| \ > - (devid) == PCI_CHIP_KABYLAKE_SRV_GT4|| \ > - (devid) == PCI_CHIP_KABYLAKE_WKS_GT4) > + (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2) > + > +#define IS_KBL_GT4(devid) ((devid) == PCI_CHIP_KABYLAKE_HALO_GT4) > > #define IS_KABYLAKE(devid) (IS_KBL_GT1(devid) || \ > IS_KBL_GT2(devid) || \ I checked the Spec, this looks right. Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 1c894d5..3967468 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -223,18 +223,13 @@ void intel_check_pch(void); #define PCI_CHIP_KABYLAKE_DT_GT2 0x5912 #define PCI_CHIP_KABYLAKE_DT_GT1_5 0x5917 #define PCI_CHIP_KABYLAKE_DT_GT1 0x5902 -#define PCI_CHIP_KABYLAKE_DT_GT4 0x5932 #define PCI_CHIP_KABYLAKE_HALO_GT2 0x591B -#define PCI_CHIP_KABYLAKE_HALO_GT3 0x592B #define PCI_CHIP_KABYLAKE_H_GT1_0 0x5908 #define PCI_CHIP_KABYLAKE_H_GT1_1 0x590B #define PCI_CHIP_KABYLAKE_HALO_GT4 0x593B #define PCI_CHIP_KABYLAKE_SRV_GT2 0x591A -#define PCI_CHIP_KABYLAKE_SRV_GT3 0x592A -#define PCI_CHIP_KABYLAKE_SRV_GT4 0x593A #define PCI_CHIP_KABYLAKE_SRV_GT1 0x590A #define PCI_CHIP_KABYLAKE_WKS_GT2 0x591D -#define PCI_CHIP_KABYLAKE_WKS_GT4 0x593D #define PCI_CHIP_BROXTON_0 0x0A84 #define PCI_CHIP_BROXTON_1 0x1A84 @@ -447,14 +442,9 @@ void intel_check_pch(void); #define IS_KBL_GT3(devid) ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0|| \ (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1|| \ - (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2|| \ - (devid) == PCI_CHIP_KABYLAKE_HALO_GT3|| \ - (devid) == PCI_CHIP_KABYLAKE_SRV_GT3) - -#define IS_KBL_GT4(devid) ((devid) == PCI_CHIP_KABYLAKE_DT_GT4|| \ - (devid) == PCI_CHIP_KABYLAKE_HALO_GT4|| \ - (devid) == PCI_CHIP_KABYLAKE_SRV_GT4|| \ - (devid) == PCI_CHIP_KABYLAKE_WKS_GT4) + (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2) + +#define IS_KBL_GT4(devid) ((devid) == PCI_CHIP_KABYLAKE_HALO_GT4) #define IS_KABYLAKE(devid) (IS_KBL_GT1(devid) || \ IS_KBL_GT2(devid) || \
This is unusual. Usually IDs listed on early stages of platform definition are kept there as reserved for later use. However these IDs here are not listed anymore in any of steppings and devices IDs tables for Kabylake on configurations overview section of BSpec. So it is better removing them before they become used in any other future platform. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- lib/intel_chipset.h | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)