| Message ID | 1466718647-19900-2-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurations overview > section of BSpec. > > So it is better removing them before they become used in any > other future platform. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/pci_ids/i965_pci_ids.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h > index 7a7897f..1566afd 100644 > --- a/include/pci_ids/i965_pci_ids.h > +++ b/include/pci_ids/i965_pci_ids.h > @@ -153,12 +153,7 @@ CHIPSET(0x5921, kbl_gt2, "Intel(R) Kabylake GT2F") > CHIPSET(0x5923, kbl_gt3, "Intel(R) Kabylake GT3") > CHIPSET(0x5926, kbl_gt3, "Intel(R) Kabylake GT3") > CHIPSET(0x5927, kbl_gt3, "Intel(R) Kabylake GT3") > -CHIPSET(0x592A, kbl_gt3, "Intel(R) Kabylake GT3") > -CHIPSET(0x592B, kbl_gt3, "Intel(R) Kabylake GT3") > -CHIPSET(0x5932, kbl_gt4, "Intel(R) Kabylake GT4") > -CHIPSET(0x593A, kbl_gt4, "Intel(R) Kabylake GT4") > CHIPSET(0x593B, kbl_gt4, "Intel(R) Kabylake GT4") > -CHIPSET(0x593D, kbl_gt4, "Intel(R) Kabylake GT4") > CHIPSET(0x22B0, chv, "Intel(R) HD Graphics (Cherrytrail)") > CHIPSET(0x22B1, chv, "Intel(R) HD Graphics XXX (Braswell)") /* Overridden in brw_get_renderer_string */ > CHIPSET(0x22B2, chv, "Intel(R) HD Graphics (Cherryview)") Verified against the spec, lgtm. Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h index 7a7897f..1566afd 100644 --- a/include/pci_ids/i965_pci_ids.h +++ b/include/pci_ids/i965_pci_ids.h @@ -153,12 +153,7 @@ CHIPSET(0x5921, kbl_gt2, "Intel(R) Kabylake GT2F") CHIPSET(0x5923, kbl_gt3, "Intel(R) Kabylake GT3") CHIPSET(0x5926, kbl_gt3, "Intel(R) Kabylake GT3") CHIPSET(0x5927, kbl_gt3, "Intel(R) Kabylake GT3") -CHIPSET(0x592A, kbl_gt3, "Intel(R) Kabylake GT3") -CHIPSET(0x592B, kbl_gt3, "Intel(R) Kabylake GT3") -CHIPSET(0x5932, kbl_gt4, "Intel(R) Kabylake GT4") -CHIPSET(0x593A, kbl_gt4, "Intel(R) Kabylake GT4") CHIPSET(0x593B, kbl_gt4, "Intel(R) Kabylake GT4") -CHIPSET(0x593D, kbl_gt4, "Intel(R) Kabylake GT4") CHIPSET(0x22B0, chv, "Intel(R) HD Graphics (Cherrytrail)") CHIPSET(0x22B1, chv, "Intel(R) HD Graphics XXX (Braswell)") /* Overridden in brw_get_renderer_string */ CHIPSET(0x22B2, chv, "Intel(R) HD Graphics (Cherryview)")
This is unusual. Usually IDs listed on early stages of platform definition are kept there as reserved for later use. However these IDs here are not listed anymore in any of steppings and devices IDs tables for Kabylake on configurations overview section of BSpec. So it is better removing them before they become used in any other future platform. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- include/pci_ids/i965_pci_ids.h | 5 ----- 1 file changed, 5 deletions(-)