| Message ID | 1470908475-24103-1-git-send-email-mika.kuoppala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL A0, right? So something else must be going on here. There also seems to be a mismatch between #2226938, #2225763 and #2225601 in terms of what the wa should be, some make reference to bit[30].
Matthew Auld <matthew.william.auld@gmail.com> writes: > But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL > A0, right? So something else must be going on here. You are right. This patch can't affect the bug in question. I haven't yet found a similar machine so it is still mystery why the write doesn't stick. -Mika > to be a mismatch between #2226938, #2225763 and #2225601 in terms of > what the wa should be, some make reference to bit[30].
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 09f01c641c14..63316a6ea46c 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -1176,7 +1176,7 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine) GEN9_GAPS_TSV_CREDIT_DISABLE)); /* WaDisableDynamicCreditSharing:kbl */ - if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0)) + if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_A0)) WA_SET_BIT(GAMT_CHKN_BIT_REG, GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
Bspec states that this wa is for A0/B0 revs and this is noted in commit b90420467232 ("drm/i915/kbl: Add WaDisableDynamicCreditSharing") But other sources state that this is for A0 only. Also evidence indicates that with some kbl variants the bit doesn't stick. So trust the other sources and limit the scope for A0 only. References: https://bugs.freedesktop.org/show_bug.cgi?id=96981 Fixes: b90420467232 ("drm/i915/kbl: Add WaDisableDynamicCreditSharing") Cc: drm-intel-fixes@lists.freedesktop.org Cc: Matthew Auld <matthew.auld@intel.com> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com> --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)