| Message ID | 1473946137-1931-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 15, 2016 at 04:28:52PM +0300, Jani Nikula wrote: > Fix sparse warning: > > drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: symbol > 'intel_dp_compute_bpp' was not declared. Should it be static? > > Fixes: f9bb705e65f6 ("drm/i915: Update bits per component for display info") > Cc: Mika Kahola <mika.kahola@intel.com> > Cc: Jim Bride <jim.bride@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Jim Bride <jim.bride@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 69cee9b0a08d..acd0c51f74d5 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock, > } > } > > -int intel_dp_compute_bpp(struct intel_dp *intel_dp, > - struct intel_crtc_state *pipe_config) > +static int intel_dp_compute_bpp(struct intel_dp *intel_dp, > + struct intel_crtc_state *pipe_config) > { > int bpp, bpc; > > -- > 2.1.4
On Thu, 15 Sep 2016, Jim Bride <jim.bride@linux.intel.com> wrote: > On Thu, Sep 15, 2016 at 04:28:52PM +0300, Jani Nikula wrote: >> Fix sparse warning: >> >> drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: symbol >> 'intel_dp_compute_bpp' was not declared. Should it be static? >> >> Fixes: f9bb705e65f6 ("drm/i915: Update bits per component for display info") >> Cc: Mika Kahola <mika.kahola@intel.com> >> Cc: Jim Bride <jim.bride@linux.intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Jim Bride <jim.bride@linux.intel.com> Thanks, pushed patches 1, 2 and 4. Waiting review on the others. BR, Jani. > >> --- >> drivers/gpu/drm/i915/intel_dp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index 69cee9b0a08d..acd0c51f74d5 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock, >> } >> } >> >> -int intel_dp_compute_bpp(struct intel_dp *intel_dp, >> - struct intel_crtc_state *pipe_config) >> +static int intel_dp_compute_bpp(struct intel_dp *intel_dp, >> + struct intel_crtc_state *pipe_config) >> { >> int bpp, bpc; >> >> -- >> 2.1.4
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 69cee9b0a08d..acd0c51f74d5 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock, } } -int intel_dp_compute_bpp(struct intel_dp *intel_dp, - struct intel_crtc_state *pipe_config) +static int intel_dp_compute_bpp(struct intel_dp *intel_dp, + struct intel_crtc_state *pipe_config) { int bpp, bpc;
Fix sparse warning: drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: symbol 'intel_dp_compute_bpp' was not declared. Should it be static? Fixes: f9bb705e65f6 ("drm/i915: Update bits per component for display info") Cc: Mika Kahola <mika.kahola@intel.com> Cc: Jim Bride <jim.bride@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)