| Message ID | 1475573357-30562-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote: > Fix sparse warning: > > drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol > 'skl_ddb_add_affected_planes' was not declared. Should it be static? > > Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes") > Cc: Lyude <cpaul@redhat.com> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas
On Tue, 04 Oct 2016, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote: > On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote: >> Fix sparse warning: >> >> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol >> 'skl_ddb_add_affected_planes' was not declared. Should it be static? >> >> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes") >> Cc: Lyude <cpaul@redhat.com> >> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Thanks, pushed to dinq. BR, Jani.
Reviewed-by: Lyude <cpaul@redhat.com> On Tue, 2016-10-04 at 12:29 +0300, Jani Nikula wrote: > Fix sparse warning: > > drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol > 'skl_ddb_add_affected_planes' was not declared. Should it be static? > > Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually > affected by ddb changes") > Cc: Lyude <cpaul@redhat.com> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > --- > > Please run sparse on your patches, please run sparse before you push. > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c > b/drivers/gpu/drm/i915/intel_pm.c > index 425544b1f733..7f1748a1e614 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3966,7 +3966,7 @@ pipes_modified(struct drm_atomic_state *state) > return ret; > } > > -int > +static int > skl_ddb_add_affected_planes(struct intel_crtc_state *cstate) > { > struct drm_atomic_state *state = cstate->base.state;
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 425544b1f733..7f1748a1e614 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -3966,7 +3966,7 @@ pipes_modified(struct drm_atomic_state *state) return ret; } -int +static int skl_ddb_add_affected_planes(struct intel_crtc_state *cstate) { struct drm_atomic_state *state = cstate->base.state;
Fix sparse warning: drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol 'skl_ddb_add_affected_planes' was not declared. Should it be static? Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes") Cc: Lyude <cpaul@redhat.com> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Please run sparse on your patches, please run sparse before you push. --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)