| Message ID | 1476977460-28088-1-git-send-email-arkadiusz.hiler@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 20, 2016 at 04:16:39PM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 (rev2) > URL : https://patchwork.freedesktop.org/series/13949/ > State : warning > > == Summary == > > Series 13949v2 drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 > https://patchwork.freedesktop.org/api/1.0/series/13949/revisions/2/mbox/ > > Test drv_module_reload_basic: > pass -> DMESG-WARN (fi-ilk-650) [ 29.416479] Setting dangerous option inject_load_failure - tainting kernel [ 30.043240] Setting dangerous option inject_load_failure - tainting kernel [ 30.700891] Setting dangerous option inject_load_failure - tainting kernel [ 31.361520] Setting dangerous option inject_load_failure - tainting kernel [ 32.178933] [drm:intel_pch_fifo_underrun_irq_handler [i915]] *ERROR* PCH transcoder B FIFO underrun Does not seem to be caused by the change. > skip -> PASS (fi-skl-6770hq) That's not caused by the change. Reference result skip the test as module i915 is still in use. > Test kms_pipe_crc_basic: > Subgroup suspend-read-crc-pipe-c: > pass -> DMESG-WARN (fi-ivb-3770) [ 415.378393] sd 0:0:0:0: [sda] Starting disk [ 415.560141] [drm:drm_edid_block_valid] *ERROR* EDID checksum is invalid, remainder is 130 [ 415.560143] Raw EDID: [ 415.560145] 00 ff ff ff ff ff ff 00 ff ff ff ff ff ff ff ff [ 415.560146] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560147] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560148] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560149] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560150] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560151] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.560152] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [ 415.671426] done. Does not seem to be caused by the change. > Results at /archive/results/CI_IGT_test/Patchwork_2777/ > > 5113d7495dab3ea4d14a7698368c6be80f6c045c drm-intel-nightly: 2016y-10m-20d-13h-31m-16s UTC integration manifest > 9eee225 drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 >
Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes: > Dropping WA because it was for early steppings. > > It is fixed in newer preproduction and all production revisions. > > v2: add references, updated commit message > > References: HSD#2126385, HSD#2131381, BSID#0764 > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Michal Winiarski <michal.winiarski@intel.com> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> Applied. Thanks for the patch. -Mika > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index e107455..32786ba 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine) > */ > } > > - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */ > /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */ > WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7, > - GEN9_ENABLE_YV12_BUGFIX | > GEN9_ENABLE_GPGPU_PREEMPTION); > > /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */ > -- > 2.7.4
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index e107455..32786ba 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine) */ } - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */ /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */ WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7, - GEN9_ENABLE_YV12_BUGFIX | GEN9_ENABLE_GPGPU_PREEMPTION); /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
Dropping WA because it was for early steppings. It is fixed in newer preproduction and all production revisions. v2: add references, updated commit message References: HSD#2126385, HSD#2131381, BSID#0764 Cc: Mika Kuoppala <mika.kuoppala@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Michal Winiarski <michal.winiarski@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 -- 1 file changed, 2 deletions(-)