diff mbox

drm/i915: Add more keywords to firmware loading message

Message ID 1479288806-17355-1-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Nov. 16, 2016, 9:33 a.m. UTC
To find out what firmware we actually loaded (from dmesg) the explicit
'dmc' and 'firmware' are missing from the info printout. Add them.

Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Imre Deak Nov. 16, 2016, 10:45 a.m. UTC | #1
On ke, 2016-11-16 at 11:33 +0200, Mika Kuoppala wrote:
> To find out what firmware we actually loaded (from dmesg) the explicit
> 'dmc' and 'firmware' are missing from the info printout. Add them.
> 
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index d7a04bc..10e9abc 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -405,7 +405,7 @@ static void csr_load_work_fn(struct work_struct *work)
>  
>  		intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
>  
> -		DRM_INFO("Finished loading %s (v%u.%u)\n",
> +		DRM_INFO("Finished loading DMC firmware %s (v%u.%u)\n",
>  			 dev_priv->csr.fw_path,
>  			 CSR_VERSION_MAJOR(csr->version),
>  			 CSR_VERSION_MINOR(csr->version));
Mika Kuoppala Nov. 21, 2016, 12:54 p.m. UTC | #2
Imre Deak <imre.deak@intel.com> writes:

> On ke, 2016-11-16 at 11:33 +0200, Mika Kuoppala wrote:
>> To find out what firmware we actually loaded (from dmesg) the explicit
>> 'dmc' and 'firmware' are missing from the info printout. Add them.
>> 
>> Cc: Imre Deak <imre.deak@intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Pushed. Thanks for review.

>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index d7a04bc..10e9abc 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -405,7 +405,7 @@ static void csr_load_work_fn(struct work_struct *work)
>>  
>>  		intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
>>  
>> -		DRM_INFO("Finished loading %s (v%u.%u)\n",
>> +		DRM_INFO("Finished loading DMC firmware %s (v%u.%u)\n",
>>  			 dev_priv->csr.fw_path,
>>  			 CSR_VERSION_MAJOR(csr->version),
>>  			 CSR_VERSION_MINOR(csr->version));
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index d7a04bc..10e9abc 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -405,7 +405,7 @@  static void csr_load_work_fn(struct work_struct *work)
 
 		intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
 
-		DRM_INFO("Finished loading %s (v%u.%u)\n",
+		DRM_INFO("Finished loading DMC firmware %s (v%u.%u)\n",
 			 dev_priv->csr.fw_path,
 			 CSR_VERSION_MAJOR(csr->version),
 			 CSR_VERSION_MINOR(csr->version));