From patchwork Fri Nov 18 11:19:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 9436229 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A56FB60469 for ; Fri, 18 Nov 2016 11:19:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8716329880 for ; Fri, 18 Nov 2016 11:19:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A0DD29885; Fri, 18 Nov 2016 11:19:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D9A0429880 for ; Fri, 18 Nov 2016 11:19:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D6AB6E94B; Fri, 18 Nov 2016 11:19:27 +0000 (UTC) X-Original-To: Intel-gfx@lists.freedesktop.org Delivered-To: Intel-gfx@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7167D6E94B for ; Fri, 18 Nov 2016 11:19:26 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id u144so5146125wmu.0 for ; Fri, 18 Nov 2016 03:19:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rTmbVbj3cmeeocQ80KUP3MbZ6V56yjP008ES1rY/4iY=; b=K8VIZCap2qIQ9psRZGuOnnuNIhs74mQ+iDPfs6hRKmU5vuUBNhvv0Xry8v0BWbtfXS byWox0K1xKY3G9IoNHifPFOsvQNitAhL5a901Soz/BQ0afpOEOz7Cyi2deGyUHbHw2zi +9W2ogb43N4KdONksJGp0+MYs6okeRc1raPwaVO1nX8X/x44mGLUdRBOJkAQUEpJfh4L zRaPo6F+X1D0oLGaljjmHO1k46plX00zmexLTEJ+QrYD/ZV+4mBzsWi1z0pVMWmlfBG1 /O+fLUF7DBmmM/MqFFP3Mcoz8z2QJI2id/n1X/Sgfv+cS8YFfkFYWzLK0uIvVWm1MtSi PJlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rTmbVbj3cmeeocQ80KUP3MbZ6V56yjP008ES1rY/4iY=; b=m7UyOtkY/yw0bUi+2eHpi4c4cyHk6vsy/xyOukeyohn0IHbGeUZeiuHLJZhphAbwnA rrUTdgvmBtFfpjdQiNHb+g7SQJuKsLCbujI1HXf7mlTvzkjlj7kiKJYTOXyO1SYdxI0J 0iRcknOoCuWFktsjCiUwKeCkK97NqIwf8ftQ4KLl76d4S4IW0kqR1hAdB5IzDJfzJR6d vB05TuKgs+AKyX70lyqYbFzYLb4/VxVetWyN7jZB5JOFE1+hXVp9dVpGcP6DXZjORPeD 3bgmaW9KwNXENCE0T4IMLdqpn1jzgf9+19AWu1mBKkNjXBVlqq/KsMduty/dmUxV5mMT i/sg== X-Gm-Message-State: AKaTC00IlV0kVWoR8d0kmEOKsNUq2uuQSOn8wIGNrZrtOj2BfdIUNTDlp8x8CcvtY+Qrfg== X-Received: by 10.194.10.72 with SMTP id g8mr749945wjb.57.1479467964811; Fri, 18 Nov 2016 03:19:24 -0800 (PST) Received: from t460p.intel ([2a02:c7d:9bd6:b000:f37e:1e07:a7d8:46cd]) by smtp.gmail.com with ESMTPSA id t84sm2829793wmt.7.2016.11.18.03.19.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 03:19:24 -0800 (PST) From: Tvrtko Ursulin X-Google-Original-From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org Date: Fri, 18 Nov 2016 11:19:17 +0000 Message-Id: <1479467957-7554-1-git-send-email-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP From: Tvrtko Ursulin Keep parameters relating to the pipe and crtc respectively together. Signed-off-by: Tvrtko Ursulin Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 200f09778776..155910c93896 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12739,9 +12739,14 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n", crtc->base.base.id, crtc->base.name, context); - DRM_DEBUG_KMS("cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n", + DRM_DEBUG_KMS("cpu_transcoder: %s, port clock: %d, ips: %i\n", transcoder_name(pipe_config->cpu_transcoder), - pipe_config->pipe_bpp, pipe_config->dither); + pipe_config->port_clock, pipe_config->ips_enabled); + + DRM_DEBUG_KMS("pipe src size: %dx%d, bpp: %i, dithering: %i, double wide: %i\n", + pipe_config->pipe_src_w, pipe_config->pipe_src_h, + pipe_config->pipe_bpp, pipe_config->dither, + pipe_config->double_wide); if (pipe_config->has_pch_encoder) intel_dump_m_n_config(pipe_config, "fdi", @@ -12765,9 +12770,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, DRM_DEBUG_KMS("adjusted mode:\n"); drm_mode_debug_printmodeline(&pipe_config->base.adjusted_mode); intel_dump_crtc_timings(&pipe_config->base.adjusted_mode); - DRM_DEBUG_KMS("port clock: %d, pipe src size: %dx%d\n", - pipe_config->port_clock, - pipe_config->pipe_src_w, pipe_config->pipe_src_h); if (INTEL_GEN(dev_priv) >= 9) DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n", @@ -12786,9 +12788,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, pipe_config->pch_pfit.size, enableddisabled(pipe_config->pch_pfit.enabled)); - DRM_DEBUG_KMS("ips: %i, double wide: %i\n", - pipe_config->ips_enabled, pipe_config->double_wide); - if (IS_BROXTON(dev_priv)) { DRM_DEBUG_KMS("dpll_hw_state: ebb0: 0x%x, ebb4: 0x%x," "pll0: 0x%x, pll1: 0x%x, pll2: 0x%x, pll3: 0x%x, "