diff mbox

drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs

Message ID 1479664226-22307-1-git-send-email-sunil.kamath@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kamath, Sunil Nov. 20, 2016, 5:50 p.m. UTC
From: "A.Sunil Kamath" <sunil.kamath@intel.com>

Better to use num_scaler itself while printing scaler_info.
This fixes a bug of printing information for the missing
second scaler on pipe C for SKL platform.

Signed-off-by: A.Sunil Kamath <sunil.kamath@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ander Conselvan de Oliveira Nov. 21, 2016, 11:46 a.m. UTC | #1
On Sun, 2016-11-20 at 23:20 +0530, sunil.kamath@intel.com wrote:
> From: "A.Sunil Kamath" <sunil.kamath@intel.com>
> 
> Better to use num_scaler itself while printing scaler_info.
> This fixes a bug of printing information for the missing
> second scaler on pipe C for SKL platform.
> 
> Signed-off-by: A.Sunil Kamath <sunil.kamath@intel.com>

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1cc971c..6c39881 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -3081,7 +3081,7 @@ static void intel_scaler_info(struct seq_file *m, struct
> intel_crtc *intel_crtc)
>  			   pipe_config->scaler_state.scaler_users,
>  			   pipe_config->scaler_state.scaler_id);
>  
> -		for (i = 0; i < SKL_NUM_SCALERS; i++) {
> +		for (i = 0; i < num_scalers; i++) {
>  			struct intel_scaler *sc =
>  					&pipe_config-
> >scaler_state.scalers[i];
>
Ander Conselvan de Oliveira Nov. 21, 2016, 11:59 a.m. UTC | #2
On Sun, 2016-11-20 at 18:16 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs
> URL   : https://patchwork.freedesktop.org/series/15621/
> State : success
> 
> == Summary ==
> 
> Series 15621v1 drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs
> https://patchwork.freedesktop.org/api/1.0/series/15621/revisions/1/mbox/
> 
> 
> fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
> fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
> fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
> fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
> fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
> fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
> fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
> fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
> fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
> fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
> fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
> fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
> fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
> fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
> fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
> fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
> 
> accd56d36a298219042d84ba9ee1b7bd66d1936c drm-intel-nightly: 2016y-11m-18d-22h-
> 35m-31s UTC integration manifest
> da14388 drm/i915: Use num_scalers instead of SKL_NUM_SCALERS in debugfs
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3064/

Pushed. Thankd for the patch.

Ander
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 1cc971c..6c39881 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -3081,7 +3081,7 @@  static void intel_scaler_info(struct seq_file *m, struct intel_crtc *intel_crtc)
 			   pipe_config->scaler_state.scaler_users,
 			   pipe_config->scaler_state.scaler_id);
 
-		for (i = 0; i < SKL_NUM_SCALERS; i++) {
+		for (i = 0; i < num_scalers; i++) {
 			struct intel_scaler *sc =
 					&pipe_config->scaler_state.scalers[i];