From patchwork Tue Dec 27 13:29:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manna, Animesh" X-Patchwork-Id: 9489229 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0F7EB60838 for ; Tue, 27 Dec 2016 13:17:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F27B3209CD for ; Tue, 27 Dec 2016 13:17:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E568925F31; Tue, 27 Dec 2016 13:17:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CC50C209CD for ; Tue, 27 Dec 2016 13:17:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A801891B5; Tue, 27 Dec 2016 13:17:25 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7907589145 for ; Tue, 27 Dec 2016 13:16:29 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 27 Dec 2016 05:16:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.33,416,1477983600"; d="scan'208"; a="1076680316" Received: from dispdev.iind.intel.com ([10.223.25.80]) by orsmga001.jf.intel.com with ESMTP; 27 Dec 2016 05:16:28 -0800 From: Animesh Manna To: intel-gfx@lists.freedesktop.org Date: Tue, 27 Dec 2016 18:59:55 +0530 Message-Id: <1482845396-23408-5-git-send-email-animesh.manna@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482845396-23408-1-git-send-email-animesh.manna@intel.com> References: <1482845396-23408-1-git-send-email-animesh.manna@intel.com> Subject: [Intel-gfx] [PATCH v3 4/5] drm/i915/bxt: Block D3 during suspend. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP For BXT, display engine can not generate interrupt when in D3. On the othen hand S0ix can be achieved without display in D3. So, Display should not put into D3 for HPD to work and will not have any power impact. v1: Initial version as RFC. v2: Based on review comment from David, condition check for hpd_wakeup_enabled is removed before calling pci_restore_state. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_drv.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 6428588..e63b5f5 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -2382,6 +2382,9 @@ static int intel_runtime_suspend(struct device *kdev) if (!IS_VALLEYVIEW(dev_priv) || !IS_CHERRYVIEW(dev_priv)) intel_hpd_poll_init(dev_priv); + if (dev_priv->vbt.hpd_wakeup_enabled) + pci_save_state(pdev); + DRM_DEBUG_KMS("Device suspended\n"); return 0; } @@ -2398,6 +2401,8 @@ static int intel_runtime_resume(struct device *kdev) DRM_DEBUG_KMS("Resuming device\n"); + pci_restore_state(pdev); + WARN_ON_ONCE(atomic_read(&dev_priv->pm.wakeref_count)); disable_rpm_wakeref_asserts(dev_priv);