diff mbox

[1/2] drm/i915/kbl: Apply WaIncreaseDefaultTLBEntries on KBL.

Message ID 1485196357-30599-1-git-send-email-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi Jan. 23, 2017, 6:32 p.m. UTC 
According to wa_database this Wa persist on KBL as it was on SKL.

Cc: Tim Gore <tim.gore@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rodrigo Vivi Jan. 23, 2017, 8:55 p.m. UTC | #1 
Ander, can I carry your rv-b on this v2?

Jani, with Ander confirmation can I merge these 2 patches?


On Mon, Jan 23, 2017 at 11:24 AM, Patchwork
<patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/i915/kbl: Apply WaIncreaseDefaultTLBEntries on KBL.
> URL   : https://patchwork.freedesktop.org/series/18421/
> State : success
>
> == Summary ==
>
> Series 18421v1 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/18421/revisions/1/mbox/
>
> Test kms_force_connector_basic:
>         Subgroup force-connector-state:
>                 dmesg-warn -> PASS       (fi-snb-2520m)
> Test kms_pipe_crc_basic:
>         Subgroup suspend-read-crc-pipe-c:
>                 dmesg-warn -> PASS       (fi-skl-6700hq)
>
> fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
> fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39
> fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22
> fi-bxt-t5700     total:79   pass:66   dwarn:0   dfail:0   fail:0   skip:12
> fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27
> fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
> fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19
> fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19
> fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
> fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
> fi-kbl-7500u     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
> fi-skl-6260u     total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13
> fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20
> fi-skl-6700k     total:246  pass:222  dwarn:3   dfail:0   fail:0   skip:21
> fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13
> fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
> fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32
>
> c34072a82a390d575f7f0394fcf92437898d75d3 drm-tip: 2017y-01m-23d-15h-54m-20s UTC integration manifest
> 9fe8064 drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.
> 3c5015f drm/i915/kbl: Apply WaIncreaseDefaultTLBEntries on KBL.
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3585/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula Jan. 24, 2017, 7:04 a.m. UTC | #2 
On Mon, 23 Jan 2017, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> Ander, can I carry your rv-b on this v2?
>
> Jani, with Ander confirmation can I merge these 2 patches?

Acked-by: Jani Nikula <jani.nikula@intel.com>


>
>
> On Mon, Jan 23, 2017 at 11:24 AM, Patchwork
> <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: series starting with [1/2] drm/i915/kbl: Apply WaIncreaseDefaultTLBEntries on KBL.
>> URL   : https://patchwork.freedesktop.org/series/18421/
>> State : success
>>
>> == Summary ==
>>
>> Series 18421v1 Series without cover letter
>> https://patchwork.freedesktop.org/api/1.0/series/18421/revisions/1/mbox/
>>
>> Test kms_force_connector_basic:
>>         Subgroup force-connector-state:
>>                 dmesg-warn -> PASS       (fi-snb-2520m)
>> Test kms_pipe_crc_basic:
>>         Subgroup suspend-read-crc-pipe-c:
>>                 dmesg-warn -> PASS       (fi-skl-6700hq)
>>
>> fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
>> fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39
>> fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22
>> fi-bxt-t5700     total:79   pass:66   dwarn:0   dfail:0   fail:0   skip:12
>> fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27
>> fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
>> fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19
>> fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19
>> fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
>> fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
>> fi-kbl-7500u     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21
>> fi-skl-6260u     total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13
>> fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20
>> fi-skl-6700k     total:246  pass:222  dwarn:3   dfail:0   fail:0   skip:21
>> fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13
>> fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
>> fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32
>>
>> c34072a82a390d575f7f0394fcf92437898d75d3 drm-tip: 2017y-01m-23d-15h-54m-20s UTC integration manifest
>> 9fe8064 drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.
>> 3c5015f drm/i915/kbl: Apply WaIncreaseDefaultTLBEntries on KBL.
>>
>> == Logs ==
>>
>> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3585/
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e808aad..cc0bb7b 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2184,12 +2184,12 @@  static void gtt_write_workarounds(struct drm_i915_private *dev_priv)
 	 * called on driver load and after a GPU reset, so you can place
 	 * workarounds here even if they get overwritten by GPU reset.
 	 */
-	/* WaIncreaseDefaultTLBEntries:chv,bdw,skl,bxt */
+	/* WaIncreaseDefaultTLBEntries:chv,bdw,skl,bxt,kbl */
 	if (IS_BROADWELL(dev_priv))
 		I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN8_L3_LRA_1_GPGPU_DEFAULT_VALUE_BDW);
 	else if (IS_CHERRYVIEW(dev_priv))
 		I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN8_L3_LRA_1_GPGPU_DEFAULT_VALUE_CHV);
-	else if (IS_SKYLAKE(dev_priv))
+	else if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv))
 		I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN9_L3_LRA_1_GPGPU_DEFAULT_VALUE_SKL);
 	else if (IS_BROXTON(dev_priv))
 		I915_WRITE(GEN8_L3_LRA_1_GPGPU, GEN9_L3_LRA_1_GPGPU_DEFAULT_VALUE_BXT);