| Message ID | 1485868546-4927-3-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On ti, 2017-01-31 at 13:15 +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > dev, file and ctx are unused. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Could either squash this to the previous commit, or have this before previous commit, to avoid going through removed code in previous patch (easier for rebasing etc.) Regards, Joonas
On 01/02/2017 07:20, Joonas Lahtinen wrote: > On ti, 2017-01-31 at 13:15 +0000, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> >> dev, file and ctx are unused. >> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Could either squash this to the previous commit, or have this before > previous commit, to avoid going through removed code in previous patch > (easier for rebasing etc.) Yes I realized that after I wrote it, but was too lazy to reorder. Same for the pretty alignment in the first patch. Always when I stumble upon those I am 50-50. Will reorder it, it makes sense. Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index ee7b7bd17e29..2991751516f8 100644 --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c @@ -50,13 +50,10 @@ #define BATCH_OFFSET_BIAS (256*1024) struct i915_execbuffer_params { - struct drm_device *dev; - struct drm_file *file; struct i915_vma *batch; u32 dispatch_flags; u32 batch_start; struct intel_engine_cs *engine; - struct i915_gem_context *ctx; struct drm_i915_gem_request *request; }; @@ -1834,11 +1831,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, * kept around beyond the duration of the IOCTL once the GPU * scheduler arrives. */ - params.dev = dev; - params.file = file; params.engine = engine; params.dispatch_flags = dispatch_flags; - params.ctx = ctx; params.batch = batch; params.batch_start = batch_start_offset; params.request = req;