diff mbox

drm/i915/glk: Fix DSI enable I/O sequence

Message ID 1488393082-30660-1-git-send-email-madhav.chauhan@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chauhan, Madhav March 1, 2017, 6:31 p.m. UTC
One of the if statement covers the next line in enable I/O sequence.
This patch correct the same by adding error message.

Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jani Nikula March 2, 2017, 2:39 p.m. UTC | #1
On Wed, 01 Mar 2017, Madhav Chauhan <madhav.chauhan@intel.com> wrote:
> One of the if statement covers the next line in enable I/O sequence.
> This patch correct the same by adding error message.
>
> Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>

Pushed, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 8e97bae3..c92004b 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -425,6 +425,7 @@ static void glk_dsi_device_ready(struct intel_encoder *encoder)
>  		if (intel_wait_for_register(dev_priv,
>  				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
>  				GLK_ULPS_NOT_ACTIVE, 20))
> +			DRM_ERROR("ULPS is still active\n");
>  
>  		/* Exit ULPS */
>  		val = I915_READ(MIPI_DEVICE_READY(port));
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 8e97bae3..c92004b 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -425,6 +425,7 @@  static void glk_dsi_device_ready(struct intel_encoder *encoder)
 		if (intel_wait_for_register(dev_priv,
 				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE,
 				GLK_ULPS_NOT_ACTIVE, 20))
+			DRM_ERROR("ULPS is still active\n");
 
 		/* Exit ULPS */
 		val = I915_READ(MIPI_DEVICE_READY(port));