diff mbox

[13/67] drm/i915/cnl: Add WaDisableReplayBufferBankArbitrationOptimization

Message ID 1491506163-14587-13-git-send-email-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi April 6, 2017, 7:15 p.m. UTC
WA to disable replay buffer destination buffer arbitration optimization.

Same Wa on previous platforms has a different name: WaToEnableHwFixForPushConstHWBug

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_engine_cs.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mika Kuoppala June 8, 2017, 4:54 p.m. UTC | #1
Rodrigo Vivi <rodrigo.vivi@intel.com> writes:

> WA to disable replay buffer destination buffer arbitration optimization.
>
> Same Wa on previous platforms has a different name: WaToEnableHwFixForPushConstHWBug
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index da819a7..7a3c8ab 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -951,6 +951,10 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)
>  	struct drm_i915_private *dev_priv = engine->i915;
>  	int ret;
>
> +	/* WaDisableReplayBufferBankArbitrationOptimization:cnl */
> +	WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
> +			  GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
> +

It is from B0 ->
But I dont think it hurts to have this blanket approach.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

>  	/* WaInPlaceDecompressionHang:cnl */
>  	WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,
>  		   GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
> -- 
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi June 8, 2017, 5:09 p.m. UTC | #2
On Thu, 2017-06-08 at 19:54 +0300, Mika Kuoppala wrote:
> Rodrigo Vivi <rodrigo.vivi@intel.com> writes:

> 

> > WA to disable replay buffer destination buffer arbitration optimization.

> >

> > Same Wa on previous platforms has a different name: WaToEnableHwFixForPushConstHWBug

> >

> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> > ---

> >  drivers/gpu/drm/i915/intel_engine_cs.c | 4 ++++

> >  1 file changed, 4 insertions(+)

> >

> > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c

> > index da819a7..7a3c8ab 100644

> > --- a/drivers/gpu/drm/i915/intel_engine_cs.c

> > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c

> > @@ -951,6 +951,10 @@ static int cnl_init_workarounds(struct intel_engine_cs *engine)

> >  	struct drm_i915_private *dev_priv = engine->i915;

> >  	int ret;

> >

> > +	/* WaDisableReplayBufferBankArbitrationOptimization:cnl */

> > +	WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,

> > +			  GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);

> > +

> 

> It is from B0 ->

> But I dont think it hurts to have this blanket approach.


we will never see an A0, so it is ok ;)

> 

> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>


Thanks

> 

> >  	/* WaInPlaceDecompressionHang:cnl */

> >  	WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,

> >  		   GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);

> > -- 

> > 1.9.1

> >

> > _______________________________________________

> > Intel-gfx mailing list

> > Intel-gfx@lists.freedesktop.org

> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index da819a7..7a3c8ab 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -951,6 +951,10 @@  static int cnl_init_workarounds(struct intel_engine_cs *engine)
 	struct drm_i915_private *dev_priv = engine->i915;
 	int ret;
 
+	/* WaDisableReplayBufferBankArbitrationOptimization:cnl */
+	WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
+			  GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
+
 	/* WaInPlaceDecompressionHang:cnl */
 	WA_SET_BIT(GEN9_GAMT_ECO_REG_RW_IA,
 		   GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);