| Message ID | 1491506163-14587-43-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 4/7/2017 12:45 AM, Rodrigo Vivi wrote: > Since we have HAS_CSR tied to the platform definition > let's use this instead of checking per platform. > > One less thing to worry when adding support to new platforms. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_csr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c > index 496a965..eecee65 100644 > --- a/drivers/gpu/drm/i915/intel_csr.c > +++ b/drivers/gpu/drm/i915/intel_csr.c > @@ -241,7 +241,7 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv) > u32 *payload = dev_priv->csr.dmc_payload; > uint32_t i, fw_size; > > - if (!IS_GEN9(dev_priv)) { > + if (!HAS_CSR(dev_priv)) { > DRM_ERROR("No CSR support available for this platform\n"); > return; > } Changes looks good to me. Reviewed-by: Animesh Manna<animesh.manna@intel.com> Regards, Animesh
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 496a965..eecee65 100644 --- a/drivers/gpu/drm/i915/intel_csr.c +++ b/drivers/gpu/drm/i915/intel_csr.c @@ -241,7 +241,7 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv) u32 *payload = dev_priv->csr.dmc_payload; uint32_t i, fw_size; - if (!IS_GEN9(dev_priv)) { + if (!HAS_CSR(dev_priv)) { DRM_ERROR("No CSR support available for this platform\n"); return; }
Since we have HAS_CSR tied to the platform definition let's use this instead of checking per platform. One less thing to worry when adding support to new platforms. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)