diff mbox

x86/gpu: CNL uses the same GMS values as SKL

Message ID 1491507569-19071-1-git-send-email-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi April 6, 2017, 7:39 p.m. UTC
From: Paulo Zanoni <paulo.r.zanoni@intel.com>

So don't forget to reserve its stolen memory bits.

v2: Adding right Cc.

Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: x86@kernel.org
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 arch/x86/kernel/early-quirks.c | 1 +
 1 file changed, 1 insertion(+)

Comments

kernel test robot April 7, 2017, 7:21 p.m. UTC | #1
Hi Paulo,

[auto build test ERROR on next-20170405]
[cannot apply to tip/x86/core v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/x86-gpu-CNL-uses-the-same-GMS-values-as-SKL/20170408-024552
config: i386-randconfig-x071-04050905 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> arch/x86/kernel/early-quirks.c:530:2: error: implicit declaration of function 'INTEL_CNL_IDS' [-Werror=implicit-function-declaration]
     INTEL_CNL_IDS(&gen9_early_ops),
     ^~~~~~~~~~~~~
   arch/x86/kernel/early-quirks.c:530:2: error: initializer element is not constant
   arch/x86/kernel/early-quirks.c:530:2: note: (near initialization for 'intel_early_ids[187].vendor')
   arch/x86/kernel/early-quirks.c:501:67: warning: missing braces around initializer [-Wmissing-braces]
    static const struct pci_device_id intel_early_ids[] __initconst = {
                                                                      ^
   arch/x86/kernel/early-quirks.c:501:67: note: (near initialization for 'intel_early_ids')
   cc1: some warnings being treated as errors

vim +/INTEL_CNL_IDS +530 arch/x86/kernel/early-quirks.c

   524		INTEL_BDW_IDS(&gen8_early_ops),
   525		INTEL_CHV_IDS(&chv_early_ops),
   526		INTEL_SKL_IDS(&gen9_early_ops),
   527		INTEL_BXT_IDS(&gen9_early_ops),
   528		INTEL_KBL_IDS(&gen9_early_ops),
   529		INTEL_GLK_IDS(&gen9_early_ops),
 > 530		INTEL_CNL_IDS(&gen9_early_ops),
   531	};
   532	
   533	static void __init

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Zanoni, Paulo R April 7, 2017, 7:21 p.m. UTC | #2
Em Sáb, 2017-04-08 às 03:21 +0800, kbuild test robot escreveu:
> Hi Paulo,
> 
> [auto build test ERROR on next-20170405]
> [cannot apply to tip/x86/core v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc5]
> [if your patch is applied to the wrong git tree, please drop us a
> note to help improve the system]

This patch is part of the CNL enabling series of 67 patches that was
just posted to intel-gfx. It won't apply unless you also apply the 57
patches that came first, and the base tree for the series is drm-intel-
nightly, not x86/core.

The ideal plan would be to have an ack from the x86 maintainers and
then apply this to the i915.ko tree. I suppose this is what was done
with the previous patches that touched this function.

> 
> url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/x86-gpu
> -CNL-uses-the-same-GMS-values-as-SKL/20170408-024552
> config: i386-randconfig-x071-04050905 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
> > 
> > > 
> > > arch/x86/kernel/early-quirks.c:530:2: error: implicit declaration
> > > of function 'INTEL_CNL_IDS' [-Werror=implicit-function-
> > > declaration]
>      INTEL_CNL_IDS(&gen9_early_ops),
>      ^~~~~~~~~~~~~
>    arch/x86/kernel/early-quirks.c:530:2: error: initializer element
> is not constant
>    arch/x86/kernel/early-quirks.c:530:2: note: (near initialization
> for 'intel_early_ids[187].vendor')
>    arch/x86/kernel/early-quirks.c:501:67: warning: missing braces
> around initializer [-Wmissing-braces]
>     static const struct pci_device_id intel_early_ids[] __initconst =
> {
>                                                                      
>  ^
>    arch/x86/kernel/early-quirks.c:501:67: note: (near initialization
> for 'intel_early_ids')
>    cc1: some warnings being treated as errors
> 
> vim +/INTEL_CNL_IDS +530 arch/x86/kernel/early-quirks.c
> 
>    524		INTEL_BDW_IDS(&gen8_early_ops),
>    525		INTEL_CHV_IDS(&chv_early_ops),
>    526		INTEL_SKL_IDS(&gen9_early_ops),
>    527		INTEL_BXT_IDS(&gen9_early_ops),
>    528		INTEL_KBL_IDS(&gen9_early_ops),
>    529		INTEL_GLK_IDS(&gen9_early_ops),
>  > 530		INTEL_CNL_IDS(&gen9_early_ops),
>    531	};
>    532	
>    533	static void __init
> 
> ---
> 0-DAY kernel test infrastructure                Open Source
> Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation
Thomas Gleixner April 7, 2017, 10:07 p.m. UTC | #3
On Thu, 6 Apr 2017, Rodrigo Vivi wrote:

> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> So don't forget to reserve its stolen memory bits.
> 
> v2: Adding right Cc.
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: x86@kernel.org
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Acked-by: Thomas Gleixner <tglx@linutronix.de>
Ye Xiaolong April 13, 2017, 1:33 a.m. UTC | #4
On 04/07, Paulo Zanoni wrote:
>Em Sáb, 2017-04-08 às 03:21 +0800, kbuild test robot escreveu:
>> Hi Paulo,
>> 
>> [auto build test ERROR on next-20170405]
>> [cannot apply to tip/x86/core v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc5]
>> [if your patch is applied to the wrong git tree, please drop us a
>> note to help improve the system]
>
>This patch is part of the CNL enabling series of 67 patches that was
>just posted to intel-gfx. It won't apply unless you also apply the 57

Thanks for the info, now we realized that it's just 1 patch out of the big
patchset, in-reply-to the patch it replaces. We are developing features to 
auto-detect such kind of patch and avoid apply it individually.

>patches that came first, and the base tree for the series is drm-intel-
>nightly, not x86/core.

Got it, we'll improve it.

Thanks,
Xiaolong
>
>The ideal plan would be to have an ack from the x86 maintainers and
>then apply this to the i915.ko tree. I suppose this is what was done
>with the previous patches that touched this function.
>
>> 
>> url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/x86-gpu
>> -CNL-uses-the-same-GMS-values-as-SKL/20170408-024552
>> config: i386-randconfig-x071-04050905 (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=i386 
>> 
>> All errors (new ones prefixed by >>):
>> 
>> > 
>> > > 
>> > > arch/x86/kernel/early-quirks.c:530:2: error: implicit declaration
>> > > of function 'INTEL_CNL_IDS' [-Werror=implicit-function-
>> > > declaration]
>>      INTEL_CNL_IDS(&gen9_early_ops),
>>      ^~~~~~~~~~~~~
>>    arch/x86/kernel/early-quirks.c:530:2: error: initializer element
>> is not constant
>>    arch/x86/kernel/early-quirks.c:530:2: note: (near initialization
>> for 'intel_early_ids[187].vendor')
>>    arch/x86/kernel/early-quirks.c:501:67: warning: missing braces
>> around initializer [-Wmissing-braces]
>>     static const struct pci_device_id intel_early_ids[] __initconst =
>> {
>>                                                                      
>>  ^
>>    arch/x86/kernel/early-quirks.c:501:67: note: (near initialization
>> for 'intel_early_ids')
>>    cc1: some warnings being treated as errors
>> 
>> vim +/INTEL_CNL_IDS +530 arch/x86/kernel/early-quirks.c
>> 
>>    524		INTEL_BDW_IDS(&gen8_early_ops),
>>    525		INTEL_CHV_IDS(&chv_early_ops),
>>    526		INTEL_SKL_IDS(&gen9_early_ops),
>>    527		INTEL_BXT_IDS(&gen9_early_ops),
>>    528		INTEL_KBL_IDS(&gen9_early_ops),
>>    529		INTEL_GLK_IDS(&gen9_early_ops),
>>  > 530		INTEL_CNL_IDS(&gen9_early_ops),
>>    531	};
>>    532	
>>    533	static void __init
>> 
>> ---
>> 0-DAY kernel test infrastructure                Open Source
>> Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel
>> Corporation
>_______________________________________________
>kbuild-all mailing list
>kbuild-all@lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all
diff mbox

Patch

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 23c4f1c..afba51a 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -527,6 +527,7 @@  struct intel_early_ops {
 	INTEL_BXT_IDS(&gen9_early_ops),
 	INTEL_KBL_IDS(&gen9_early_ops),
 	INTEL_GLK_IDS(&gen9_early_ops),
+	INTEL_CNL_IDS(&gen9_early_ops),
 };
 
 static void __init