diff mbox

[i-g-t,3/3] lib/cfl: Add PCI Ids for U SKU in CFl

Message ID 1498062899-10659-3-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha June 21, 2017, 4:34 p.m. UTC
From: anushasr <anusha.srivatsa@intel.com>

Follow the spec and add ID for U SKU

v2: Update IDs.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 lib/i915_pciids.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Taylor, Clinton A June 21, 2017, 7:48 p.m. UTC | #1
On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
> From: anushasr <anusha.srivatsa@intel.com>
>
> Follow the spec and add ID for U SKU
>
> v2: Update IDs.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>   lib/i915_pciids.h | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index c319e37..71cce60 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -346,8 +346,15 @@
>   	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
>   	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
>   
> +#define INTEL_CFL_U_IDS(info) \
> +	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
0x3EA8 is marked as not POR in the current documentation.

-Clint


> +
>   #define INTEL_CFL_IDS(info) \
>   	INTEL_CFL_S_IDS(info), \
> -	INTEL_CFL_H_IDS(info)
> +	INTEL_CFL_H_IDS(info), \
> +	INTEL_CFL_U_IDS(info)
>   
>   #endif /* _I915_PCIIDS_H */
Srivatsa, Anusha June 21, 2017, 9:19 p.m. UTC | #2
>-----Original Message-----

>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of

>Clint Taylor

>Sent: Wednesday, June 21, 2017 12:48 PM

>To: intel-gfx@lists.freedesktop.org

>Subject: Re: [Intel-gfx] [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl

>

>

>

>On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:

>> From: anushasr <anusha.srivatsa@intel.com>

>>

>> Follow the spec and add ID for U SKU

>>

>> v2: Update IDs.

>>

>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

>> ---

>>   lib/i915_pciids.h | 9 ++++++++-

>>   1 file changed, 8 insertions(+), 1 deletion(-)

>>

>> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h index

>> c319e37..71cce60 100644

>> --- a/lib/i915_pciids.h

>> +++ b/lib/i915_pciids.h

>> @@ -346,8 +346,15 @@

>>   	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \

>>   	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */

>>

>> +#define INTEL_CFL_U_IDS(info) \

>> +	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \

>> +	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \

>> +	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \

>> +	INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */

>0x3EA8 is marked as not POR in the current documentation.


Wanted to match the IDs everywhere. The above list of IDs is the same even in kernel code and in libdrm .

Anusha 
>-Clint

>

>

>> +

>>   #define INTEL_CFL_IDS(info) \

>>   	INTEL_CFL_S_IDS(info), \

>> -	INTEL_CFL_H_IDS(info)

>> +	INTEL_CFL_H_IDS(info), \

>> +	INTEL_CFL_U_IDS(info)

>>

>>   #endif /* _I915_PCIIDS_H */

>

>_______________________________________________

>Intel-gfx mailing list

>Intel-gfx@lists.freedesktop.org

>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index c319e37..71cce60 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -346,8 +346,15 @@ 
 	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
 
+#define INTEL_CFL_U_IDS(info) \
+	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
+
 #define INTEL_CFL_IDS(info) \
 	INTEL_CFL_S_IDS(info), \
-	INTEL_CFL_H_IDS(info)
+	INTEL_CFL_H_IDS(info), \
+	INTEL_CFL_U_IDS(info)
 
 #endif /* _I915_PCIIDS_H */