From patchwork Fri Sep 1 07:51:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kahola, Mika" X-Patchwork-Id: 9933703 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2137C6021C for ; Fri, 1 Sep 2017 07:49:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1427928581 for ; Fri, 1 Sep 2017 07:49:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0931A28584; Fri, 1 Sep 2017 07:49:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CCDCF28581 for ; Fri, 1 Sep 2017 07:49:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0198189B05; Fri, 1 Sep 2017 07:49:22 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00028899BC for ; Fri, 1 Sep 2017 07:49:20 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2017 00:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.41,457,1498546800"; d="scan'208"; a="1168172637" Received: from sorvi.fi.intel.com ([10.237.72.154]) by orsmga001.jf.intel.com with ESMTP; 01 Sep 2017 00:48:57 -0700 From: Mika Kahola To: intel-gfx@lists.freedesktop.org Date: Fri, 1 Sep 2017 10:51:00 +0300 Message-Id: <1504252261-28964-2-git-send-email-mika.kahola@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504252261-28964-1-git-send-email-mika.kahola@intel.com> References: <1504252261-28964-1-git-send-email-mika.kahola@intel.com> Subject: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP According to spec we should send SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for v3+ VBT's. Testing with VBT v3 the current implementation yields the following error message *ERROR* Video mode command 0x00000041 send failed. To get rid of this error message, let's limit SHUTDOWN only for VBT versions 3 or higher. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 2a0f5d3..b48b9b7 100644 --- a/drivers/gpu/drm/i915/intel_dsi.c +++ b/drivers/gpu/drm/i915/intel_dsi.c @@ -916,7 +916,7 @@ static void intel_dsi_disable(struct intel_encoder *encoder, * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing * has shown that the v3 sequence works for v2 VBTs too */ - if (is_vid_mode(intel_dsi)) { + if (is_vid_mode(intel_dsi) && dev_priv->vbt.dsi.seq_version > 3) { /* Send Shutdown command to the panel in LP mode */ for_each_dsi_port(port, intel_dsi->ports) dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);