@@ -150,8 +150,6 @@ int intel_guc_enter_sleep(struct intel_guc *guc)
if (guc->fw.load_status != INTEL_UC_FIRMWARE_SUCCESS)
return 0;
- gen9_disable_guc_interrupts(dev_priv);
-
ctx = dev_priv->kernel_context;
data[0] = INTEL_GUC_ACTION_ENTER_S_STATE;
@@ -167,7 +165,7 @@ int intel_guc_enter_sleep(struct intel_guc *guc)
* intel_guc_exit_sleep() - notify GuC exit from sleep state
* @guc: guc structure
*/
-int intel_guc_exit_sleep(struct intel_guc *guc)
+static int intel_guc_exit_sleep(struct intel_guc *guc)
{
struct drm_i915_private *dev_priv = guc_to_i915(guc);
struct i915_gem_context *ctx;
@@ -176,9 +174,6 @@ int intel_guc_exit_sleep(struct intel_guc *guc)
if (guc->fw.load_status != INTEL_UC_FIRMWARE_SUCCESS)
return 0;
- if (i915.guc_log_level >= 0)
- gen9_enable_guc_interrupts(dev_priv);
-
ctx = dev_priv->kernel_context;
data[0] = INTEL_GUC_ACTION_EXIT_S_STATE;
@@ -188,3 +183,38 @@ int intel_guc_exit_sleep(struct intel_guc *guc)
return intel_guc_send(guc, data, ARRAY_SIZE(data));
}
+
+int intel_guc_runtime_suspend(struct intel_guc *guc)
+{
+ struct drm_i915_private *dev_priv = guc_to_i915(guc);
+ int ret;
+
+ ret = intel_guc_enter_sleep(guc);
+ if (ret) {
+ DRM_ERROR("GuC enter sleep failed (%d)\n", ret);
+ return ret;
+ }
+
+ i915_ggtt_disable_guc(dev_priv);
+ gen9_disable_guc_interrupts(dev_priv);
+
+ return 0;
+}
+
+int intel_guc_runtime_resume(struct intel_guc *guc)
+{
+ struct drm_i915_private *dev_priv = guc_to_i915(guc);
+ int ret;
+
+ if (i915.guc_log_level >= 0)
+ gen9_enable_guc_interrupts(dev_priv);
+ i915_ggtt_enable_guc(dev_priv);
+
+ ret = intel_guc_exit_sleep(guc);
+ if (ret) {
+ DRM_ERROR("GuC exit sleep failed (%d)\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
@@ -132,7 +132,8 @@ struct intel_guc {
int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len);
int intel_guc_sample_forcewake(struct intel_guc *guc);
int intel_guc_enter_sleep(struct intel_guc *guc);
-int intel_guc_exit_sleep(struct intel_guc *guc);
+int intel_guc_runtime_suspend(struct intel_guc *guc);
+int intel_guc_runtime_resume(struct intel_guc *guc);
static inline int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len)
{
@@ -425,12 +425,34 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
int intel_uc_runtime_suspend(struct drm_i915_private *dev_priv)
{
- return intel_guc_enter_sleep(&dev_priv->guc);
+ int ret;
+
+ if (!i915.enable_guc_loading)
+ return 0;
+
+ ret = intel_guc_runtime_suspend(&dev_priv->guc);
+ if (ret)
+ return ret;
+
+ guc_disable_communication(&dev_priv->guc);
+
+ return 0;
}
int intel_uc_runtime_resume(struct drm_i915_private *dev_priv)
{
- return intel_guc_exit_sleep(&dev_priv->guc);
+ int ret;
+
+ if (!i915.enable_guc_loading)
+ return 0;
+
+ ret = guc_enable_communication(&dev_priv->guc);
+ if (ret) {
+ DRM_ERROR("GuC enable communication failed (%d)\n", ret);
+ return ret;
+ }
+
+ return intel_guc_runtime_resume(&dev_priv->guc);
}
int intel_uc_suspend(struct drm_i915_private *dev_priv)
Apart from configuring interrupts, we need to update the ggtt invalidate interface and GuC communication on Suspend. This functionality can be reused for other suspend and reset paths. Prepared GuC specific helpers to handle these suspend/resume tasks namely - intel_guc_runtime_suspend, intel_guc_runtime_resume. Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Michał Winiarski <michal.winiarski@intel.com> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> --- drivers/gpu/drm/i915/intel_guc.c | 42 ++++++++++++++++++++++++++++++++++------ drivers/gpu/drm/i915/intel_guc.h | 3 ++- drivers/gpu/drm/i915/intel_uc.c | 26 +++++++++++++++++++++++-- 3 files changed, 62 insertions(+), 9 deletions(-)