diff mbox

drm: Add DPCD definitions for DP 1.4 FEC feature

Message ID 1511387341-10857-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha Nov. 22, 2017, 9:49 p.m. UTC
Forward Error Correction is supported on DP 1.4.
This patch adds corresponding DPCD register definitions.

Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Jani Nikula Nov. 23, 2017, 7:15 a.m. UTC | #1
On Wed, 22 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> Forward Error Correction is supported on DP 1.4.
> This patch adds corresponding DPCD register definitions.

Needs to be posted on dri-devel.

BR,
Jani.


>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 9049ef1..b0eee16 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -284,6 +284,35 @@
>  # define DP_DSC_BITS_PER_PIXEL_1_2          0x3
>  # define DP_DSC_BITS_PER_PIXEL_1            0x4
>  
> +/* DP Forward error Correction Registers */
> +#define DP_FEC_CAPABILITY		    0x090
> +# define DP_FEC_CAPABLE			    (1 << 0)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP  (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP    (1 << 2)
> +# define DP_FEC_BIT_ERROR_COUNT_CAP	    (1 << 3)
> +
> +#define DP_FEC_CONFIGURATION		    0x120
> +# define DP_FEC_READY			    (1 << 0)
> +# define DP_FEC_ERR_COUNT_DIS		    (0 << 1)
> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT	    (1 << 1)
> +# define DP_FEC_CORR_BLK_ERROR_COUNT	    (2 << 1)
> +# define DP_FEC_BIT_ERROR_COUNT		    (3 << 1)
> +# define DP_FEC_LANE_0_SELECT		    (0 << 4)
> +# define DP_FEC_LANE_1_SELECT		    (1 << 4)
> +# define DP_FEC_LANE_2_SELECT		    (2 << 4)
> +# define DP_FEC_LANE_3_SELECT		    (3 << 4)
> +
> +#define DP_FEC_STATUS			    0x280
> +# define DP_FEC_EN_DETECTED		    (1 << 0)
> +# define DP_FEC_DEC_DETECTED		    (1 << 1)
> +
> +#define DP_FEC_ERROR_COUNT_1		    0x0281
> +# define DP_FEC_ERR_COUNT_7_0(err_count)    (err_count << 0)
> +
> +#define DP_FEC_ERROR_COUNT_2		    0x0282
> +# define DP_FEC_ERR_COUNT_14_8(err_count)   (err_count << 0)
> +# define DP_FEC_ERR_COUNT_VALID		    (1 << 7)
> +
>  #define DP_PSR_SUPPORT                      0x070   /* XXX 1.2? */
>  # define DP_PSR_IS_SUPPORTED                1
>  # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */
Srivatsa, Anusha Nov. 28, 2017, 12:59 a.m. UTC | #2
>-----Original Message-----
>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>Sent: Wednesday, November 22, 2017 11:15 PM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>gfx@lists.freedesktop.org
>Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Ville Syrjala
><ville.syrjala@linux.intel.com>; Navare, Manasi D <manasi.d.navare@intel.com>
>Subject: Re: [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature
>
>On Wed, 22 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
>> Forward Error Correction is supported on DP 1.4.
>> This patch adds corresponding DPCD register definitions.
>
>Needs to be posted on dri-devel.

Sent to dri-devel too. Thanks Jani.

Anusha
>BR,
>Jani.
>
>
>>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>  include/drm/drm_dp_helper.h | 29 +++++++++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 9049ef1..b0eee16 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -284,6 +284,35 @@
>>  # define DP_DSC_BITS_PER_PIXEL_1_2          0x3
>>  # define DP_DSC_BITS_PER_PIXEL_1            0x4
>>
>> +/* DP Forward error Correction Registers */
>> +#define DP_FEC_CAPABILITY		    0x090
>> +# define DP_FEC_CAPABLE			    (1 << 0)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP  (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP    (1 << 2)
>> +# define DP_FEC_BIT_ERROR_COUNT_CAP	    (1 << 3)
>> +
>> +#define DP_FEC_CONFIGURATION		    0x120
>> +# define DP_FEC_READY			    (1 << 0)
>> +# define DP_FEC_ERR_COUNT_DIS		    (0 << 1)
>> +# define DP_FEC_UNCORR_BLK_ERROR_COUNT	    (1 << 1)
>> +# define DP_FEC_CORR_BLK_ERROR_COUNT	    (2 << 1)
>> +# define DP_FEC_BIT_ERROR_COUNT		    (3 << 1)
>> +# define DP_FEC_LANE_0_SELECT		    (0 << 4)
>> +# define DP_FEC_LANE_1_SELECT		    (1 << 4)
>> +# define DP_FEC_LANE_2_SELECT		    (2 << 4)
>> +# define DP_FEC_LANE_3_SELECT		    (3 << 4)
>> +
>> +#define DP_FEC_STATUS			    0x280
>> +# define DP_FEC_EN_DETECTED		    (1 << 0)
>> +# define DP_FEC_DEC_DETECTED		    (1 << 1)
>> +
>> +#define DP_FEC_ERROR_COUNT_1		    0x0281
>> +# define DP_FEC_ERR_COUNT_7_0(err_count)    (err_count << 0)
>> +
>> +#define DP_FEC_ERROR_COUNT_2		    0x0282
>> +# define DP_FEC_ERR_COUNT_14_8(err_count)   (err_count << 0)
>> +# define DP_FEC_ERR_COUNT_VALID		    (1 << 7)
>> +
>>  #define DP_PSR_SUPPORT                      0x070   /* XXX 1.2? */
>>  # define DP_PSR_IS_SUPPORTED                1
>>  # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */
>
>--
>Jani Nikula, Intel Open Source Technology Center
diff mbox

Patch

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 9049ef1..b0eee16 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -284,6 +284,35 @@ 
 # define DP_DSC_BITS_PER_PIXEL_1_2          0x3
 # define DP_DSC_BITS_PER_PIXEL_1            0x4
 
+/* DP Forward error Correction Registers */
+#define DP_FEC_CAPABILITY		    0x090
+# define DP_FEC_CAPABLE			    (1 << 0)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT_CAP  (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT_CAP    (1 << 2)
+# define DP_FEC_BIT_ERROR_COUNT_CAP	    (1 << 3)
+
+#define DP_FEC_CONFIGURATION		    0x120
+# define DP_FEC_READY			    (1 << 0)
+# define DP_FEC_ERR_COUNT_DIS		    (0 << 1)
+# define DP_FEC_UNCORR_BLK_ERROR_COUNT	    (1 << 1)
+# define DP_FEC_CORR_BLK_ERROR_COUNT	    (2 << 1)
+# define DP_FEC_BIT_ERROR_COUNT		    (3 << 1)
+# define DP_FEC_LANE_0_SELECT		    (0 << 4)
+# define DP_FEC_LANE_1_SELECT		    (1 << 4)
+# define DP_FEC_LANE_2_SELECT		    (2 << 4)
+# define DP_FEC_LANE_3_SELECT		    (3 << 4)
+
+#define DP_FEC_STATUS			    0x280
+# define DP_FEC_EN_DETECTED		    (1 << 0)
+# define DP_FEC_DEC_DETECTED		    (1 << 1)
+
+#define DP_FEC_ERROR_COUNT_1		    0x0281
+# define DP_FEC_ERR_COUNT_7_0(err_count)    (err_count << 0)
+
+#define DP_FEC_ERROR_COUNT_2		    0x0282
+# define DP_FEC_ERR_COUNT_14_8(err_count)   (err_count << 0)
+# define DP_FEC_ERR_COUNT_VALID		    (1 << 7)
+
 #define DP_PSR_SUPPORT                      0x070   /* XXX 1.2? */
 # define DP_PSR_IS_SUPPORTED                1
 # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */