diff mbox

[i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()

Message ID 1518471002-3278-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha Feb. 12, 2018, 9:30 p.m. UTC 
Rework the rotate and reflect subtests by checking the
crtc supported properties against the ones that the
test is testing. Remove the hardcoded platform names in
igt_require()

Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 tests/kms_rotation_crc.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Arkadiusz Hiler Feb. 23, 2018, 10:56 a.m. UTC | #1 
On Tue, Feb 13, 2018 at 01:38:21AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
> URL   : https://patchwork.freedesktop.org/series/38108/
> State : failure
> 
> == Summary ==
> 
> Test kms_rotation_crc:
>         Subgroup primary-rotation-180:
>                 pass       -> SKIP       (shard-snb)
>                 pass       -> SKIP       (shard-hsw)
>                 pass       -> SKIP       (shard-apl) fdo#103925 +1
>         Subgroup exhaust-fences:
>                 skip       -> PASS       (shard-apl)
>         Subgroup sprite-rotation-270:
>                 pass       -> SKIP       (shard-apl) fdo#103356 +1
>         Subgroup primary-rotation-270:
>                 pass       -> SKIP       (shard-apl)
>         Subgroup cursor-rotation-180:
>                 pass       -> SKIP       (shard-snb)
>                 pass       -> SKIP       (shard-hsw) fdo#102614
>                 pass       -> SKIP       (shard-apl)
>         Subgroup sprite-rotation-180:
>                 pass       -> SKIP       (shard-snb)
>                 pass       -> SKIP       (shard-hsw)
>                 pass       -> SKIP       (shard-apl)

This is strange. Those tests were previously passing on apl, hsw and snb
and now there are skipping? Is the kernel misadvertising properties for
those GENs?
diff mbox

Patch

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 0cd5c6e..49d57a2 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -373,9 +373,6 @@  static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
 		igt_plane_t *plane;
 		int i, j;
 
-		if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
-			continue;
-
 		igt_output_set_pipe(output, pipe);
 
 		plane = igt_output_get_plane_type(output, plane_type);
@@ -558,9 +555,7 @@  igt_main
 		igt_subtest_f("%s-rotation-%s",
 			      plane_test_str(subtest->plane),
 			      rot_test_str(subtest->rot)) {
-			igt_require(!(subtest->rot &
-				    (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
-				    gen >= 9);
+			igt_require(igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot);
 			data.rotation = subtest->rot;
 			test_plane_rotation(&data, subtest->plane, false);
 		}
@@ -596,9 +591,8 @@  igt_main
 		igt_subtest_f("primary-%s-reflect-x-%s",
 			      tiling_test_str(reflect_x->tiling),
 			      rot_test_str(reflect_x->rot)) {
-			igt_require(gen >= 10 ||
-				    (IS_CHERRYVIEW(data.devid) && reflect_x->rot == IGT_ROTATION_0
-				     && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
+			igt_require((igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot) &&
+				    (reflect_x->rot == IGT_ROTATION_0 && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
 			data.rotation = (IGT_REFLECT_X | reflect_x->rot);
 			data.override_tiling = reflect_x->tiling;
 			test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, false);