| Message ID | 1548160909-11491-1-git-send-email-juhapekka.heikkila@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 | expand |
Please ignore this. This patch is all wrong. /Juha-Pekka On 22.1.2019 14.41, Juha-Pekka Heikkila wrote: > Using visible plane width for testing NV12 source suitability may fail > randomly when plane is clipped. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109381 > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > drivers/gpu/drm/i915/intel_sprite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c > index b02d3d9..a15c5ef 100644 > --- a/drivers/gpu/drm/i915/intel_sprite.c > +++ b/drivers/gpu/drm/i915/intel_sprite.c > @@ -1516,7 +1516,7 @@ static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_s > { > const struct drm_framebuffer *fb = plane_state->base.fb; > unsigned int rotation = plane_state->base.rotation; > - int src_w = drm_rect_width(&plane_state->base.src) >> 16; > + int src_w = plane_state->base.fb->width; > > /* Display WA #1106 */ > if (fb->format->format == DRM_FORMAT_NV12 && src_w & 3 && >
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index b02d3d9..a15c5ef 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -1516,7 +1516,7 @@ static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_s { const struct drm_framebuffer *fb = plane_state->base.fb; unsigned int rotation = plane_state->base.rotation; - int src_w = drm_rect_width(&plane_state->base.src) >> 16; + int src_w = plane_state->base.fb->width; /* Display WA #1106 */ if (fb->format->format == DRM_FORMAT_NV12 && src_w & 3 &&
Using visible plane width for testing NV12 source suitability may fail randomly when plane is clipped. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109381 Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)