| Message ID | 1555324408-26054-12-git-send-email-swati2.sharma@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: adding state checker for gamma lut values | expand |
On Mon, 15 Apr 2019, Swati Sharma <swati2.sharma@intel.com> wrote: > v3: Rebase > > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > --- > drivers/gpu/drm/i915/intel_color.c | 49 ++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/i915/intel_color.h | 6 +++++ > drivers/gpu/drm/i915/intel_display.c | 10 ++++++++ > 3 files changed, 65 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c > index e2703f9..867c1de 100644 > --- a/drivers/gpu/drm/i915/intel_color.c > +++ b/drivers/gpu/drm/i915/intel_color.c > @@ -1500,6 +1500,55 @@ static void ilk_get_color_config(struct intel_crtc_state *crtc_state) > ilk_get_gamma_config(crtc_state); > } > > +static inline bool gamma_err_check(struct drm_color_lut *sw_lut, struct drm_color_lut *hw_lut, u32 err) > +{ > + return ((abs((long)hw_lut->red - sw_lut->red)) >= err) || > + ((abs((long)hw_lut->blue - sw_lut->blue)) >= err) || > + ((abs((long)hw_lut->green - sw_lut->green)) >= err); > +} > + > +bool intel_compare_color_lut(struct drm_property_blob *blob1, > + struct drm_property_blob *blob2, > + u32 gamma_mode) Please prefix the function name with intel_color_ like I mentioned earlier in the series. I don't think it's obvious what a boolean function called "compare" should return. I see intel_compare_link_m_n() and intel_compare_infoframe() I think they're equally bad. intel_color_lut_match() or intel_color_lut_equal() would be obvious. The C strcmp() is the notorious example where 0 means equal. > +{ > + struct drm_color_lut *sw_lut = blob1->data; > + struct drm_color_lut *hw_lut = blob2->data; > + int sw_lut_size, hw_lut_size, i; > + u32 bit_precision, err; > + > + if (!blob1 || !blob2) > + return false; > + > + switch(gamma_mode) { > + case GAMMA_MODE_MODE_8BIT: > + bit_precision = 8; > + break; > + case GAMMA_MODE_MODE_10BIT: > + bit_precision = 10; > + break; > + case GAMMA_MODE_MODE_12BIT: > + bit_precision = 12; > + break; > + default: It's customary to just add the default label above the correct label above. BR, Jani. > + bit_precision = 8; > + } > + > + err = 0xffff >> bit_precision; > + > + sw_lut_size = drm_color_lut_size(blob1); > + hw_lut_size = drm_color_lut_size(blob2); > + > + if (sw_lut_size != hw_lut_size) > + return false; > + > + for (i = 0; i < sw_lut_size; i++) { > + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) > + return false; > + } > + > + return true; > +} > + > void intel_color_init(struct intel_crtc *crtc) > { > struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); > diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h > index 7ca304f..575003f 100644 > --- a/drivers/gpu/drm/i915/intel_color.h > +++ b/drivers/gpu/drm/i915/intel_color.h > @@ -6,13 +6,19 @@ > #ifndef __INTEL_COLOR_H__ > #define __INTEL_COLOR_H__ > > +#include <linux/types.h> > + > struct intel_crtc_state; > struct intel_crtc; > +struct drm_property_blob; > > void intel_color_init(struct intel_crtc *crtc); > int intel_color_check(struct intel_crtc_state *crtc_state); > void intel_color_commit(const struct intel_crtc_state *crtc_state); > void intel_color_load_luts(const struct intel_crtc_state *crtc_state); > void intel_get_color_config(struct intel_crtc_state *crtc_state); > +bool intel_compare_color_lut(struct drm_property_blob *blob1, > + struct drm_property_blob *blob2, > + u32 gamma_mode); > > #endif /* __INTEL_COLOR_H__ */ > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 0fc9dab..b074f00 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -12236,6 +12236,14 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv) > } \ > } while (0) > > +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ > + if (!intel_compare_color_lut(current_config->name, pipe_config->name, gamma_mode)) { \ > + pipe_config_err(adjust, __stringify(name), \ > + "hw_state doesn't match sw_state\n"); \ > + ret = false; \ > + } \ > +} while (0) > + > #define PIPE_CONF_QUIRK(quirk) \ > ((current_config->quirks | pipe_config->quirks) & (quirk)) > > @@ -12379,6 +12387,8 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv) > PIPE_CONF_CHECK_INFOFRAME(spd); > PIPE_CONF_CHECK_INFOFRAME(hdmi); > > + PIPE_CONF_CHECK_COLOR_LUT(base.gamma_lut, pipe_config->gamma_mode); > + > #undef PIPE_CONF_CHECK_X > #undef PIPE_CONF_CHECK_I > #undef PIPE_CONF_CHECK_BOOL
Hi Swati,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-adding-state-checker-for-gamma-lut-values/20190416-021708
base: git://anongit.freedesktop.org/drm-intel for-linux-next
New smatch warnings:
drivers/gpu/drm/i915/intel_color.c:1519 intel_compare_color_lut() warn: variable dereferenced before check 'blob1' (see line 1514)
drivers/gpu/drm/i915/intel_color.c:1519 intel_compare_color_lut() warn: variable dereferenced before check 'blob2' (see line 1515)
# https://github.com/0day-ci/linux/commit/14a61c5a3c40291ad8779909b5fdc261aad53df3
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 14a61c5a3c40291ad8779909b5fdc261aad53df3
vim +/blob1 +1519 drivers/gpu/drm/i915/intel_color.c
14a61c5a Swati Sharma 2019-04-15 1510 bool intel_compare_color_lut(struct drm_property_blob *blob1,
14a61c5a Swati Sharma 2019-04-15 1511 struct drm_property_blob *blob2,
14a61c5a Swati Sharma 2019-04-15 1512 u32 gamma_mode)
14a61c5a Swati Sharma 2019-04-15 1513 {
14a61c5a Swati Sharma 2019-04-15 @1514 struct drm_color_lut *sw_lut = blob1->data;
^^^^^^^^^^^
14a61c5a Swati Sharma 2019-04-15 @1515 struct drm_color_lut *hw_lut = blob2->data;
^^^^^^^^^^^
14a61c5a Swati Sharma 2019-04-15 1516 int sw_lut_size, hw_lut_size, i;
14a61c5a Swati Sharma 2019-04-15 1517 u32 bit_precision, err;
14a61c5a Swati Sharma 2019-04-15 1518
14a61c5a Swati Sharma 2019-04-15 @1519 if (!blob1 || !blob2)
^^^^^ ^^^^^^
14a61c5a Swati Sharma 2019-04-15 1520 return false;
14a61c5a Swati Sharma 2019-04-15 1521
14a61c5a Swati Sharma 2019-04-15 1522 switch(gamma_mode) {
14a61c5a Swati Sharma 2019-04-15 1523 case GAMMA_MODE_MODE_8BIT:
14a61c5a Swati Sharma 2019-04-15 1524 bit_precision = 8;
14a61c5a Swati Sharma 2019-04-15 1525 break;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e2703f9..867c1de 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++ b/drivers/gpu/drm/i915/intel_color.c @@ -1500,6 +1500,55 @@ static void ilk_get_color_config(struct intel_crtc_state *crtc_state) ilk_get_gamma_config(crtc_state); } +static inline bool gamma_err_check(struct drm_color_lut *sw_lut, struct drm_color_lut *hw_lut, u32 err) +{ + return ((abs((long)hw_lut->red - sw_lut->red)) >= err) || + ((abs((long)hw_lut->blue - sw_lut->blue)) >= err) || + ((abs((long)hw_lut->green - sw_lut->green)) >= err); +} + +bool intel_compare_color_lut(struct drm_property_blob *blob1, + struct drm_property_blob *blob2, + u32 gamma_mode) +{ + struct drm_color_lut *sw_lut = blob1->data; + struct drm_color_lut *hw_lut = blob2->data; + int sw_lut_size, hw_lut_size, i; + u32 bit_precision, err; + + if (!blob1 || !blob2) + return false; + + switch(gamma_mode) { + case GAMMA_MODE_MODE_8BIT: + bit_precision = 8; + break; + case GAMMA_MODE_MODE_10BIT: + bit_precision = 10; + break; + case GAMMA_MODE_MODE_12BIT: + bit_precision = 12; + break; + default: + bit_precision = 8; + } + + err = 0xffff >> bit_precision; + + sw_lut_size = drm_color_lut_size(blob1); + hw_lut_size = drm_color_lut_size(blob2); + + if (sw_lut_size != hw_lut_size) + return false; + + for (i = 0; i < sw_lut_size; i++) { + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) + return false; + } + + return true; +} + void intel_color_init(struct intel_crtc *crtc) { struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h index 7ca304f..575003f 100644 --- a/drivers/gpu/drm/i915/intel_color.h +++ b/drivers/gpu/drm/i915/intel_color.h @@ -6,13 +6,19 @@ #ifndef __INTEL_COLOR_H__ #define __INTEL_COLOR_H__ +#include <linux/types.h> + struct intel_crtc_state; struct intel_crtc; +struct drm_property_blob; void intel_color_init(struct intel_crtc *crtc); int intel_color_check(struct intel_crtc_state *crtc_state); void intel_color_commit(const struct intel_crtc_state *crtc_state); void intel_color_load_luts(const struct intel_crtc_state *crtc_state); void intel_get_color_config(struct intel_crtc_state *crtc_state); +bool intel_compare_color_lut(struct drm_property_blob *blob1, + struct drm_property_blob *blob2, + u32 gamma_mode); #endif /* __INTEL_COLOR_H__ */ diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0fc9dab..b074f00 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12236,6 +12236,14 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv) } \ } while (0) +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ + if (!intel_compare_color_lut(current_config->name, pipe_config->name, gamma_mode)) { \ + pipe_config_err(adjust, __stringify(name), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ +} while (0) + #define PIPE_CONF_QUIRK(quirk) \ ((current_config->quirks | pipe_config->quirks) & (quirk)) @@ -12379,6 +12387,8 @@ static bool fastboot_enabled(struct drm_i915_private *dev_priv) PIPE_CONF_CHECK_INFOFRAME(spd); PIPE_CONF_CHECK_INFOFRAME(hdmi); + PIPE_CONF_CHECK_COLOR_LUT(base.gamma_lut, pipe_config->gamma_mode); + #undef PIPE_CONF_CHECK_X #undef PIPE_CONF_CHECK_I #undef PIPE_CONF_CHECK_BOOL
v3: Rebase Signed-off-by: Swati Sharma <swati2.sharma@intel.com> --- drivers/gpu/drm/i915/intel_color.c | 49 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_color.h | 6 +++++ drivers/gpu/drm/i915/intel_display.c | 10 ++++++++ 3 files changed, 65 insertions(+)