| Message ID | 1622547939-8157-1-git-send-email-vidya.srinivas@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t,RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests | expand |
On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote: > tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests > > Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant > code similar to constant_alpha_min or basic_alpha > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com> Please make the first line of the commit message a statement that tells what change you're making, and in the full text block state why that's done. "Fix a-b-c tests" is useless later when browsing oneliner git logs. It doesn't even tell which problem is fixed. Meaning, something like: == tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant Similar change has already been done in tests xxx and yyy. This fixes CRC mismatches seen with some Gen11 systems. Signed-off-by etc ==
Thank you so much Petri. Apologies for the incorrect commit message. I will submit the patch with the clear commit message. Regards Vidya -----Original Message----- From: Latvala, Petri <petri.latvala@intel.com> Sent: Tuesday, June 1, 2021 7:11 PM To: Srinivas, Vidya <vidya.srinivas@intel.com> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests On Tue, Jun 01, 2021 at 05:15:39PM +0530, Vidya Srinivas wrote: > tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests > > Few Gen11 systems show CRC mismatch. Make > coverage-vs-premult-vs-constant code similar to constant_alpha_min or > basic_alpha > > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com> Please make the first line of the commit message a statement that tells what change you're making, and in the full text block state why that's done. "Fix a-b-c tests" is useless later when browsing oneliner git logs. It doesn't even tell which problem is fixed. Meaning, something like: == tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant Similar change has already been done in tests xxx and yyy. This fixes CRC mismatches seen with some Gen11 systems. Signed-off-by etc == -- Petri Latvala
On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote: > > Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant > code similar to constant_alpha_min or basic_alpha > Tested on ChromeOS on JSL (Drawlat) Tested-by: Mark Yacoub <markyacoub@chromium.org> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com> > --- > tests/kms_plane_alpha_blend.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c > index a37cb27c7d62..224d79bd1749 100644 > --- a/tests/kms_plane_alpha_blend.c > +++ b/tests/kms_plane_alpha_blend.c > @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t > igt_display_t *display = &data->display; > igt_crc_t ref_crc = {}, crc = {}; > > - /* Set a background color on the primary fb for testing */ > - if (plane->type != DRM_PLANE_TYPE_PRIMARY) > - igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb); > - > igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage"); > igt_plane_set_fb(plane, &data->argb_fb_cov_7e); > igt_display_commit2(display, COMMIT_ATOMIC); > -- > 2.7.4 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev
Thank you very much Mark, for testing the patch and providing the "Tested-by" tag. Regards Vidya -----Original Message----- From: Mark Yacoub <markyacoub@chromium.org> Sent: Saturday, June 5, 2021 12:12 AM To: Srinivas, Vidya <vidya.srinivas@intel.com> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Fix coverage-vs-premult-vs-constant tests On Tue, Jun 1, 2021 at 7:54 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote: > > Few Gen11 systems show CRC mismatch. Make > coverage-vs-premult-vs-constant code similar to constant_alpha_min or > basic_alpha > Tested on ChromeOS on JSL (Drawlat) Tested-by: Mark Yacoub <markyacoub@chromium.org> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com> > --- > tests/kms_plane_alpha_blend.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/kms_plane_alpha_blend.c > b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 > 100644 > --- a/tests/kms_plane_alpha_blend.c > +++ b/tests/kms_plane_alpha_blend.c > @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t > igt_display_t *display = &data->display; > igt_crc_t ref_crc = {}, crc = {}; > > - /* Set a background color on the primary fb for testing */ > - if (plane->type != DRM_PLANE_TYPE_PRIMARY) > - igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb); > - > igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage"); > igt_plane_set_fb(plane, &data->argb_fb_cov_7e); > igt_display_commit2(display, COMMIT_ATOMIC); > -- > 2.7.4 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev
diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c index a37cb27c7d62..224d79bd1749 100644 --- a/tests/kms_plane_alpha_blend.c +++ b/tests/kms_plane_alpha_blend.c @@ -447,10 +447,6 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t igt_display_t *display = &data->display; igt_crc_t ref_crc = {}, crc = {}; - /* Set a background color on the primary fb for testing */ - if (plane->type != DRM_PLANE_TYPE_PRIMARY) - igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), &data->gray_fb); - igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage"); igt_plane_set_fb(plane, &data->argb_fb_cov_7e); igt_display_commit2(display, COMMIT_ATOMIC);
Few Gen11 systems show CRC mismatch. Make coverage-vs-premult-vs-constant code similar to constant_alpha_min or basic_alpha Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com> --- tests/kms_plane_alpha_blend.c | 4 ---- 1 file changed, 4 deletions(-)