From patchwork Tue Aug 18 19:33:13 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Jesse Barnes <jbarnes@virtuousgeek.org>
X-Patchwork-Id: 42408
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7IJXLf5014861
	for <patchwork-intel-gfx@patchwork.kernel.org>;
	Tue, 18 Aug 2009 19:33:21 GMT
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
	by gabe.freedesktop.org (Postfix) with ESMTP id 22E289E8F9;
	Tue, 18 Aug 2009 12:33:21 -0700 (PDT)
X-Original-To: intel-gfx@lists.freedesktop.org
Delivered-To: intel-gfx@lists.freedesktop.org
Received: from outbound-mail-03.bluehost.com (outbound-mail-03.bluehost.com
	[69.89.21.13])
	by gabe.freedesktop.org (Postfix) with SMTP id E79A39E774
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 18 Aug 2009 12:33:18 -0700 (PDT)
Received: (qmail 11298 invoked by uid 0); 18 Aug 2009 19:33:17 -0000
Received: from unknown (HELO box514.bluehost.com) (74.220.219.114)
	by outboundproxy1.bluehost.com with SMTP; 18 Aug 2009 19:33:17 -0000
Received: from [75.111.28.251] (helo=jbarnes-g45)
	by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.69) (envelope-from <jbarnes@virtuousgeek.org>)
	id 1MdUQn-0003qU-BY; Tue, 18 Aug 2009 13:33:17 -0600
Date: Tue, 18 Aug 2009 12:33:13 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org, eric@anholt.net
Message-ID: <20090818123313.0a95baca@jbarnes-g45>
X-Mailer: Claws Mail 3.7.2 (GTK+ 2.17.5; i486-pc-linux-gnu)
Mime-Version: 1.0
X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org}
	{sentby:smtp auth 75.111.28.251 authed with
	jbarnes@virtuousgeek.org}
Subject: [Intel-gfx] [PATCH] drm/i915: increase default latency constant
X-BeenThere: intel-gfx@lists.freedesktop.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Intel graphics driver community testing & development
	<intel-gfx.lists.freedesktop.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org

Some i915/i945 platforms have a fairly high memory latency in certain
situations, so increase our constant a bit to avoid FIFO underruns.
The effect should be positive on other platforms as well; we'll have a
bit more insurance against a busy memory subsystem due to the extra
FIFO entries.

Fixes fdo bug #23368.

Tested-by: Sven Arvidsson <sa@whiz.se>
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d6fce21..80c9473 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2005,7 +2005,7 @@ static void igd_enable_cxsr(struct drm_device *dev, unsigned long clock,
 	return;
 }
 
-const static int latency_ns = 3000; /* default for non-igd platforms */
+const static int latency_ns = 5000; /* default for non-igd platforms */
 
 static int intel_get_fifo_size(struct drm_device *dev, int plane)
 {