From patchwork Fri Sep 18 15:35:51 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesse Barnes X-Patchwork-Id: 48555 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8IFa4qf008527 for ; Fri, 18 Sep 2009 15:36:04 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFB6BA0263; Fri, 18 Sep 2009 08:36:03 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from outbound-mail-07.bluehost.com (outbound-mail-07.bluehost.com [69.89.17.207]) by gabe.freedesktop.org (Postfix) with SMTP id 36077A025A for ; Fri, 18 Sep 2009 08:36:00 -0700 (PDT) Received: (qmail 17605 invoked by uid 0); 18 Sep 2009 15:36:00 -0000 Received: from unknown (HELO box514.bluehost.com) (74.220.219.114) by outboundproxy1.bluehost.com with SMTP; 18 Sep 2009 15:36:00 -0000 Received: from [75.111.28.251] (helo=jbarnes-g45) by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1MofVA-0001CS-42; Fri, 18 Sep 2009 09:36:00 -0600 Date: Fri, 18 Sep 2009 08:35:51 -0700 From: Jesse Barnes To: Jesse Barnes Message-ID: <20090918083551.363af17e@jbarnes-g45> In-Reply-To: <20090918082922.0fab7eb9@jbarnes-g45> References: <20090917150828.14247b2f@jbarnes-g45> <4AB34FC6.8030906@fisher-privat.net> <20090918082922.0fab7eb9@jbarnes-g45> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.17.5; i486-pc-linux-gnu) Mime-Version: 1.0 X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.28.251 authed with jbarnes@virtuousgeek.org} Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] Request for testing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org On Fri, 18 Sep 2009 08:29:22 -0700 Jesse Barnes wrote: > On Fri, 18 Sep 2009 11:15:50 +0200 > Alexey Fisher wrote: > > > Jesse Barnes schrieb: > > > Eric asked me to track drm-intel patches while he was out this > > > week, so I just dumped a bunch in the drm-intel-next branch of my > > > drm-intel tree at kernel.org > > > git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/drm-intel.git > > > > > > It includes several patchset that have been baking awhile: > > > - reset support for 965 (from Ben and myself) > > > - memory shrinker/madvise support (from Chris) > > > - Ironlake fixes (from Zhenyu) > > > - misc bug fixes (mostly me fixing my own bugs) > > > > > > So please pull it down and hammer on it. Hopefully the merge > > > window will still be open next week so we can get this set into > > > 2.6.32. > > > > > > Thanks, > > > > > > With this kommit my PC (Intel DG45ID) freez on boot. I can't get > > any error messages. > > Reverting it make the system work. > > > > commit 8082400327d8d2ca54254b593644942bed0edd25 > > Author: Jesse Barnes > > Date: Thu Sep 10 15:28:06 2009 -0700 > > > > drm/i915: framebuffer compression for pre-GM45 > > > > This patch adds framebuffer compression (good for about ~0.5W > > power savings in the best case) support for pre-GM45 chips. GM45+ > > have a new, > > more flexible FBC scheme that will be added in a separate > > patch. > > > > FBC can't always be enabled: the compressed buffer must be > > physically contiguous and reside in stolen space. So if you have a > > large display and a small amount of stolen memory, you may not be > > able to take advantage of FBC. In some cases, a BIOS setting > > controls how much stolen space is available. Increasing this to 8 > > or 16M can help. > > > > Signed-off-by: Jesse Barnes > > Signed-off-by: Eric Anholt > > Hm, I thought I fixed that hang with > > commit c1a1cdc159e211f045290f61ac95092e9708f5bc > Author: Jesse Barnes > Date: Wed Sep 16 15:05:00 2009 -0700 > > drm/i915: fix startup hang on some non-mobile platforms > > Can you confirm you had that in your tree? If so, this might help: diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index cb0f4f9..b8c2a4f 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -1064,6 +1064,9 @@ static void intel_update_fbc(struct drm_crtc *crtc, if (!i915_powersave) return; + if (!I915_HAS_FBC(dev)) + return; + if (!crtc->fb) return;