From patchwork Wed May 18 15:58:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesse Barnes X-Patchwork-Id: 793842 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4IG3a1t021556 for ; Wed, 18 May 2011 16:03:56 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22A6C9F052 for ; Wed, 18 May 2011 08:58:36 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 7D4469E7A4 for ; Wed, 18 May 2011 08:58:17 -0700 (PDT) Received: (qmail 20575 invoked by uid 0); 18 May 2011 15:58:16 -0000 Received: from unknown (HELO box514.bluehost.com) (74.220.219.114) by oproxy8.bluehost.com with SMTP; 18 May 2011 15:58:16 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=lj5YB8NK1Oqrj3NU0zMuGTyFPd/6eSnhpWJR0q/O0LYoDaRgj//23Xln0fEF8e4yiZuSZu4/408FRLJNsKp1JYpDP6WXhCzzuyiwyiNMT+VLEGpILKLM14OdYflAlEhu; Received: from c-67-161-37-189.hsd1.ca.comcast.net ([67.161.37.189] helo=jbarnes-desktop) by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1QMj8a-00014Y-1p; Wed, 18 May 2011 09:58:16 -0600 Date: Wed, 18 May 2011 08:58:02 -0700 From: Jesse Barnes To: Ted Phelps Message-ID: <20110518085802.03ac1383@jbarnes-desktop> In-Reply-To: <3988.1305719483@orpheus.gnusto.com> References: <1304028785-10583-1-git-send-email-jbarnes@virtuousgeek.org> <1304028785-10583-3-git-send-email-jbarnes@virtuousgeek.org> <3988.1305719483@orpheus.gnusto.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.161.37.189 authed with jbarnes@virtuousgeek.org} Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [SNB: Regression] Re: [PATCH 02/19] drm/i915: split irq handling into per-chipset functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 18 May 2011 16:03:56 +0000 (UTC) On Wed, 18 May 2011 21:51:23 +1000 Ted Phelps wrote: > > Jesse Barnes writes: > > Set the IRQ handling functions in driver load so they'll just be used > > directly, rather than branching over most of the code in the chipset > > functions. > > I'm seeing a kernel panic on my SNB i7-2600K with keithp/drm-intel-next > (61e499b). I've bisected to 4697995 -- the commit mentioned in the > subject. > > My photo of the stack trace is a bit blurry, but below is my attempted > transcription of the the stack. I can't read the addresses at all; > please let me know if you'd like me to obtain a better dump. > > Call Trace: > > queue_work_op+0x1d/0x30 > queue_work+0x35/0x50 > ironlake_irq_handler+0xec9/0xfa0 [i915] > handle_irq_event_percpu+0x75/0x260 > handle_edge_irq+0x6f/0x110 > handle_irq+0x1d/0x30 > do_IRQ+0x58/0xe9 > common_interrupt+0x13/0x13 > ... more stuff that I assume is irrelevent ... > > Please let me know if I can provide additional useful information. Please try this patch. diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 349a03e..e0aed1e 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1736,6 +1736,7 @@ void ironlake_irq_preinstall(struct drm_device *dev) INIT_WORK(&dev_priv->hotplug_work, i915_hotplug_work_func); INIT_WORK(&dev_priv->error_work, i915_error_work_func); + INIT_WORK(&dev_priv->rps_work, gen6_pm_rps_work); I915_WRITE(HWSTAM, 0xeffe);