diff mbox

gen6 (SNB) GPU still stalling besides latest patches

Message ID 20110621095527.2ea996ee@jbarnes-desktop (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes June 21, 2011, 4:55 p.m. UTC 
On Tue, 21 Jun 2011 18:12:56 +0200 (CEST)
"Nicolas Kalkhof" <nkalkhof@web.de> wrote:

> Hi Jesse,
> 
> thanks for the infiormation. I've switched rc6 off by
> echo 0 > /sys/module/i915/parameters/i915_enable_rc6
> this should do it, right?
> cat /sys/module/i915/parameters/i915_enable_rc6 yields "0"
> 
> Are you referring to this patch? https://lkml.org/lkml/2011/6/17/371
> It should be included in kernel 3.0-rc4 and didn't help here :(

So there are actually a few things that could go wrong in this area.
The problem may be RC6 related, but it could also be turbo related (our
GPU frequency adjustment code).  Can you boot without the module
parameter and try this patch and see what happens (after a cold boot)?

Thanks,
Jesse
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d
index 81a9059..3c589cb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7788,9 +7788,6 @@  void intel_modeset_init(struct drm_device *dev)
                intel_init_emon(dev);
        }
 
-       if (IS_GEN6(dev))
-               gen6_enable_rps(dev_priv);
-
        INIT_WORK(&dev_priv->idle_work, intel_idle_update);
        setup_timer(&dev_priv->idle_timer, intel_gpu_idle_timer,
                    (unsigned long)dev);