From patchwork Mon Feb 11 22:27:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesse Barnes X-Patchwork-Id: 2126221 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 56C30DF2A1 for ; Mon, 11 Feb 2013 22:26:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2136CE627F for ; Mon, 11 Feb 2013 14:26:50 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from oproxy13-pub.unifiedlayer.com (oproxy13-pub.unifiedlayer.com [69.89.16.30]) by gabe.freedesktop.org (Postfix) with SMTP id EFE13E5C34 for ; Mon, 11 Feb 2013 14:26:40 -0800 (PST) Received: (qmail 23603 invoked by uid 0); 11 Feb 2013 22:26:38 -0000 Received: from unknown (HELO box514.bluehost.com) (74.220.219.114) by oproxy13.unifiedlayer.com with SMTP; 11 Feb 2013 22:26:38 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuousgeek.org; s=default; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=ZTf0qqa+TsogpVajlks05JZ52pF3vqFI4a9nsJ2jTNI=; b=JUltcZdIVwpGNmjlBIuyqWXKrdF2cxXld7cPCgqOBUeXP6KyXroeZk4h7J/xdP1SUeZV2tr3UcMHTPlAz5Rp9bQygTDUUeiCcnigSSm/D1KsB7PN9l4sP2Yd2Cosvb+Q; Received: from [67.161.37.189] (port=45771 helo=jbarnes-desktop) by box514.bluehost.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1U51pe-0007YH-JL; Mon, 11 Feb 2013 15:26:38 -0700 Date: Mon, 11 Feb 2013 14:27:08 -0800 From: Jesse Barnes To: Daniel Vetter Message-ID: <20130211142708.3b2d6e6e@jbarnes-desktop> In-Reply-To: References: <5114c59c.TwL73aRElKJaIFRT%fengguang.wu@intel.com> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.161.37.189 authed with jbarnes@virtuousgeek.org} Cc: "Rafael J. Wysocki" , intel-gfx , kbuild test robot Subject: Re: [Intel-gfx] ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org On Fri, 8 Feb 2013 10:51:48 +0100 Daniel Vetter wrote: > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot > wrote: > > tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly > > head: 69f0d09dfd2d0579241389aee18ba50aa39d0de2 > > commit: d6bc5b0603e5bea1b5a214d21c0aba8518f1a01f fb: add support for drivers not needing VT switch at suspend/resume time > > date: 2 days ago > > config: i386-randconfig-b031 (attached as .config) > > > > All error/warnings: > > > >>> ERROR: "pm_vt_switch_unregister" [drivers/video/fb.ko] undefined! > >>> ERROR: "pm_vt_switch_required" [drivers/video/fb.ko] undefined! > > I guess there's a select CONFIG_VT_CONSOLE_SLEEP missing somewhere ... > Or at least a few stubs in headers if that's not selected. The > offending config option itself was created itself to fix compile fail: > > commit 37cce26b32142f09a8967f6d238178af654b20de > Author: H Hartley Sweeten > Date: Wed Sep 21 22:47:55 2011 +0200 > > PM / VT: Cleanup #if defined uglyness and fix compile error > > Jesse, Rafael? I think this should work, but I don't build with PM_SLEEP disabled... Jesse From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Mon, 11 Feb 2013 14:25:43 -0800 Subject: [PATCH] pm: provide stubs for PM VT console switch routines If PM_SLEEP is disabled, we need stub versions of these functions. Signed-off-by: Jesse Barnes --- include/linux/pm.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/pm.h b/include/linux/pm.h index 98310eb..02e404b 100644 --- a/include/linux/pm.h +++ b/include/linux/pm.h @@ -35,9 +35,18 @@ extern void (*pm_idle)(void); extern void (*pm_power_off)(void); extern void (*pm_power_off_prepare)(void); +#ifdef CONFIG_VT_CONSOLE_SLEEP struct device; /* we have a circular dep with device.h */ extern void pm_vt_switch_required(struct device *dev, bool required); extern void pm_vt_switch_unregister(struct device *dev); +#else +static inline void pm_vt_switch_required(struct device *dev, bool required) +{ +} +static inline void pm_vt_switch_unregister(struct device *dev) +{ +} +#endif /* CONFIG_VT_CONSOLE_SLEEP */ /* * Device power management