From patchwork Mon Feb 15 20:26:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 8318401 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AF7A39F6E4 for ; Mon, 15 Feb 2016 20:26:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB30A2034E for ; Mon, 15 Feb 2016 20:26:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9382F20328 for ; Mon, 15 Feb 2016 20:26:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 309BF6E1DF; Mon, 15 Feb 2016 20:26:38 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E5F6E1DF for ; Mon, 15 Feb 2016 20:26:36 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 15 Feb 2016 12:26:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,452,1449561600"; d="scan'208";a="912916825" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 15 Feb 2016 12:26:34 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 15 Feb 2016 22:26:33 +0200 Date: Mon, 15 Feb 2016 22:26:33 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Tore Anderson Message-ID: <20160215202633.GA23290@intel.com> References: <20160215201723.02814b3b@envy.w5.y.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160215201723.02814b3b@envy.w5.y.home> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [BUG] HDMI 12bpc causing occasional flickering and blanking X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Feb 15, 2016 at 08:17:23PM +0100, Tore Anderson wrote: > Hello, > > Since upgrading to the Fedora 4.3 kernel package, the picture on my the > BenQ M2700 HD monitor I've got connected to my HP EliteBook Folio 9470m > laptop began having issues. The monitor is connected with a DP+-to-HDMI > cable (HDMI in the monitor end), and the resolution I'm using is > 1920x1080. > > The symptoms are brief flickers of which looks like a thin horizontal > line (or maybe more) overlaying the picture for a very brief period. > This is ofte often (but not always) followed by the entire picture > going completely black (kind of like when xscreensaver blanks the > screen). Usually, the picture returns after maybe a second, but > sometimes it remains off for several seconds before returning. It might > also be that these blankings happen without a horizontal line flicker > having occurred immediately before, thought it's hard to be certain > because the flickers are very brief. > > The laptop's internal screen is not impacted, the picture there remains > stable while the external screen is flickering/blanking (including if > both screens are set up in xrandr to show the same output). > > Most of the time the flickers and blankings happens only occasionally, > and be just a minor annoyance. However, some times it gets really bad, > and the screen spends a majority of the time black - making it > impossible to use the system. I have not determined anything that will > with 100% certainty cause the symptoms to manifest themselves, but I do > have a feeling that it is more likely to happen if the picture is > mostly white/bright (e.g., when displaying a web browser window or an > application such as gitk), and also after having resumed from suspend. > But flickering/blanking certainly does happen if the screen showing > mostly black xterms and without having suspended/resumed too. > > I bisected the problem, which resulted in the following verdict: > > 7a0baa6234468aa387f9b8a1a79dc2a4b4821f67 is the first bad commit > commit 7a0baa6234468aa387f9b8a1a79dc2a4b4821f67 > Author: Ville Syrjälä > Date: Tue Jun 30 15:33:54 2015 +0300 > > Revert "drm/i915: Disable 12bpc hdmi for now" > > HDMI 12bpc should be working fine now. Let it loose. > > This reverts commit 5e3daaca09f5158eff9c92290faa1d2001ecc6e4. > > v2: Rebased due to CHV/BXT port clock check improvemnts > > Signed-off-by: Ville Syrjälä > Reviewed-and-tested-by: Imre Deak > Signed-off-by: Daniel Vetter > > I also confirmed that the problem is still present in drm-intel-nightly > as of today (8ed1804). I'm currently running 8ed1804 + 7a0baa6 reverted > and the symptoms are gone. > > I've uploaded a kernel logs with drm.debug=0xe here: > > http://filebin.net/r3nlwu09y2 > > One file is from when running 8ed1804 (with some comments of when the symptoms > occurred added by me), the other file is from right now (running > 8ed1804 + 7a0baa6 reverted) - I've not yet experienced any issues since > booting the system with this kernel. Could you test the following hack while using a 1920x1080 mode with 148.5 MHz dotclock, and see if there's any improvement? diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 4e1321b96522..ea24de873e14 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12842,6 +12842,11 @@ intel_modeset_pipe_config(struct drm_crtc *crtc, clear_intel_crtc_state(pipe_config); + if (pipe_config->base.adjusted_mode.clock == 148500) { + DRM_ERROR("adjusting dotclock\n"); + pipe_config->base.adjusted_mode.clock = 148800; + } + pipe_config->cpu_transcoder = (enum transcoder) to_intel_crtc(crtc)->pipe;