drm/i915/fbdev: Call intel_unpin_fb_obj() on release

Commit Message

Chris Wilson April 22, 2016, 12:11 p.m. UTC

On Fri, Apr 22, 2016 at 12:59:12PM +0100, Tvrtko Ursulin wrote:
> 
> On 22/04/16 10:00, Chris Wilson wrote:
> >Something about CI results being hidden and not seeing the same failures
> >locally...
> 
> Didn't really understand any of that. Is think blocking the
> premature unpin series? Is the warning only appearing with that
> series or is it something already present?

I meant I can't see the results. The WARN is coming on a different set
of machines, but only seems to be after this series (from watching CI
mails) and previously the WARN seemed to be pertinent (i.e. it was a
drm_mm memory manager warning.

We are missing something like:

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index ff7d563c5623..01cd061ab573 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -552,6 +552,8 @@  void i915_gem_context_fini(struct drm_device *dev)
        i915_gem_context_unreference(dctx);
        dev_priv->kernel_context = NULL;
 
+       WARN_ON(!list_empty(&dev_priv->context_list));
+
        ida_destroy(&dev_priv->context_hw_ida);
 }
-Chris