From patchwork Fri Apr 22 12:11:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 8911411 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 746E39F39A for ; Fri, 22 Apr 2016 12:11:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A65D9201F2 for ; Fri, 22 Apr 2016 12:11:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B9F1720122 for ; Fri, 22 Apr 2016 12:11:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91D196E90F; Fri, 22 Apr 2016 12:11:33 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 118076E90F for ; Fri, 22 Apr 2016 12:11:31 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from nuc-i3427.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 58712669-1500048 for multiple; Fri, 22 Apr 2016 13:11:33 +0100 Received: by nuc-i3427.alporthouse.com (sSMTP sendmail emulation); Fri, 22 Apr 2016 13:11:22 +0100 Date: Fri, 22 Apr 2016 13:11:22 +0100 From: Chris Wilson To: Tvrtko Ursulin Message-ID: <20160422121122.GG17454@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Mika Kuoppala References: <1461311222-32406-1-git-send-email-chris@chris-wilson.co.uk> <5719E533.6000806@linux.intel.com> <20160422090029.GZ17454@nuc-i3427.alporthouse.com> <571A1210.5060701@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <571A1210.5060701@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Apr 22, 2016 at 12:59:12PM +0100, Tvrtko Ursulin wrote: > > On 22/04/16 10:00, Chris Wilson wrote: > >Something about CI results being hidden and not seeing the same failures > >locally... > > Didn't really understand any of that. Is think blocking the > premature unpin series? Is the warning only appearing with that > series or is it something already present? I meant I can't see the results. The WARN is coming on a different set of machines, but only seems to be after this series (from watching CI mails) and previously the WARN seemed to be pertinent (i.e. it was a drm_mm memory manager warning. We are missing something like: diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c index ff7d563c5623..01cd061ab573 100644 --- a/drivers/gpu/drm/i915/i915_gem_context.c +++ b/drivers/gpu/drm/i915/i915_gem_context.c @@ -552,6 +552,8 @@ void i915_gem_context_fini(struct drm_device *dev) i915_gem_context_unreference(dctx); dev_priv->kernel_context = NULL; + WARN_ON(!list_empty(&dev_priv->context_list)); + ida_destroy(&dev_priv->context_hw_ida); } -Chris