From patchwork Mon Oct 3 12:45:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9360525 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D8989607D8 for ; Mon, 3 Oct 2016 12:45:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C93AD28416 for ; Mon, 3 Oct 2016 12:45:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA25926861; Mon, 3 Oct 2016 12:45:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0DB0F2896F for ; Mon, 3 Oct 2016 12:45:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BB7B6E405; Mon, 3 Oct 2016 12:45:24 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CA876E404 for ; Mon, 3 Oct 2016 12:45:22 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id b201so9376186wmb.1 for ; Mon, 03 Oct 2016 05:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id; bh=/zSE6zD49cFw88x/A47qID2/YGuil1X+6GmEGCL4O54=; b=XDoarbptN1AoswP18Wu7nJ42FSyEyZI+J72WMZeS4KsPCIWkeM9YgKpoeXWmxK8jpl rhrrGHX0ImGC24Iq6oLJFanIS1NlK0jVd7oh9BUgtKFxDMEkoso72Ad4JW3BNHH0FPAI OBuvh+wSnlNcFcx5P+bIvfkwvYQz0LOHvgvELoxh+73PRZieJK7VUQWVVBpKCG66l8Ut wSoNXmc74Pao9y5Y6sd3jbpHX0fTDqcjLomUICcGvWUk5SUQN3qNhRSOLFJfjAKVycN8 pwr/xF6xT8e0+360K/LOx1VL3LVz7eSfe/ImStbLWSOjaWpwE7xOCssIRVDUcJ+Vw9jn 7+4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=/zSE6zD49cFw88x/A47qID2/YGuil1X+6GmEGCL4O54=; b=REe0rTY7Qw8m1v7fwlynlHQAjaAOGZfjx4apAPPHgrPHEKcNhBvZBwDXK1k28kch8R GVf2I/sg5c0vNjV8c18npTu+/nmM5xPLSFbg3E+OUcExfSBcqpUyGutfP2qRF9fRO8VR DsRwnKlHZl/Q9KPWtKi6DA1O0dosJk/RZFPBi78bkKwVhnJqZ65btuaT7QjSa1hqU0Rh b6mkwahGQQOmV7lonffvYPvud3riotAmXHG+2661ENoUIf1h7d/HODAywh5xUECqVwDH ccaQvkHltstWy4hyYye8/eVMfDQ2V5bnAHPC5Sjkac2FGrUmQxr9+ZsZxEgqhYC23nMO xSUA== X-Gm-Message-State: AA6/9RmQFyADcQ1DFmEn8muCpfq2SuFLae+7whViOdAb4EIF1wi5EW8BnA3NoUe7tSk+aw== X-Received: by 10.194.5.97 with SMTP id r1mr11418759wjr.36.1475498720887; Mon, 03 Oct 2016 05:45:20 -0700 (PDT) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id o2sm34174948wjo.3.2016.10.03.05.45.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 05:45:20 -0700 (PDT) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Mon, 3 Oct 2016 13:45:14 +0100 Message-Id: <20161003124516.12388-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.9.3 Subject: [Intel-gfx] [CI 1/3] drm/i915: Just clear the mmiodebug before a register access X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP When we enable the per-register access mmiodebug, it is to detect which access is illegal. Reporting on earlier untraced access outside of the mmiodebug does not help debugging (as the suspicion is immediately put upon the current register which is not at fault)! References: https://bugs.freedesktop.org/show_bug.cgi?id=97985 Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala Cc: stable@vger.kernel.org --- drivers/gpu/drm/i915/intel_uncore.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index a9b6c936aadd..ee2306a79747 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -796,10 +796,9 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv, const bool read, const bool before) { - if (WARN(check_for_unclaimed_mmio(dev_priv), - "Unclaimed register detected %s %s register 0x%x\n", - before ? "before" : "after", - read ? "reading" : "writing to", + if (WARN(check_for_unclaimed_mmio(dev_priv) && !before, + "Unclaimed %s register 0x%x\n", + read ? "read from" : "write to", i915_mmio_reg_offset(reg))) i915.mmio_debug--; /* Only report the first N failures */ }