| Message ID | 20161019074250.22124-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016.10.19 08:42:49 +0100, Chris Wilson wrote: > Deprecated functions; it is also not clear whether these are called from > the right context. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Thanks, Chris. Already did a same fix on https://github.com/01org/gvt-linux/commit/abd8dc57b13cccfa493553b4e64ba175070bbb0c > --- > drivers/gpu/drm/i915/gvt/execlist.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > index c50a3d1a5131..a9d04c378755 100644 > --- a/drivers/gpu/drm/i915/gvt/execlist.c > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > @@ -498,7 +498,7 @@ static void release_shadow_batch_buffer(struct intel_vgpu_workload *workload) > > list_for_each_entry_safe(entry_obj, temp, &workload->shadow_bb, > list) { > - drm_gem_object_unreference(&(entry_obj->obj->base)); > + i915_gem_object_put(entry_obj->obj); > kvfree(entry_obj->va); > list_del(&entry_obj->list); > kfree(entry_obj); > @@ -511,7 +511,7 @@ static void release_shadow_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx) > if (wa_ctx->indirect_ctx.size == 0) > return; > > - drm_gem_object_unreference(&(wa_ctx->indirect_ctx.obj->base)); > + i915_gem_object_put(wa_ctx->indirect_ctx.obj); > kvfree(wa_ctx->indirect_ctx.shadow_va); > } > > -- > 2.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c index c50a3d1a5131..a9d04c378755 100644 --- a/drivers/gpu/drm/i915/gvt/execlist.c +++ b/drivers/gpu/drm/i915/gvt/execlist.c @@ -498,7 +498,7 @@ static void release_shadow_batch_buffer(struct intel_vgpu_workload *workload) list_for_each_entry_safe(entry_obj, temp, &workload->shadow_bb, list) { - drm_gem_object_unreference(&(entry_obj->obj->base)); + i915_gem_object_put(entry_obj->obj); kvfree(entry_obj->va); list_del(&entry_obj->list); kfree(entry_obj); @@ -511,7 +511,7 @@ static void release_shadow_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx) if (wa_ctx->indirect_ctx.size == 0) return; - drm_gem_object_unreference(&(wa_ctx->indirect_ctx.obj->base)); + i915_gem_object_put(wa_ctx->indirect_ctx.obj); kvfree(wa_ctx->indirect_ctx.shadow_va); }
Deprecated functions; it is also not clear whether these are called from the right context. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gvt/execlist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)