From patchwork Thu Dec 22 10:56:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9484681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6EB5E601D3 for ; Thu, 22 Dec 2016 10:56:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 691202818E for ; Thu, 22 Dec 2016 10:56:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5DF8E28324; Thu, 22 Dec 2016 10:56:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E192F2818E for ; Thu, 22 Dec 2016 10:56:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 123A46F210; Thu, 22 Dec 2016 10:56:48 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8740A6E188 for ; Thu, 22 Dec 2016 10:56:34 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id g23so35501000wme.1 for ; Thu, 22 Dec 2016 02:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=SnkRbluJKNKCXqGjXdEAdbMv8i5e7kEhOYD7HeLmM00=; b=cbM856mz/BLFejRoQRPkjGOJWq9iktg6O3s91Mfvl2tyIMaXdfWx/b/rZO+HXZdCjS YIRudkxxb6le+GN038jnQqQuxMiTQyRPu9xcJA0PPSEAjdKqP2lXNBnL+cJknBj/qAhh suk0DqBkcIPXdNTcGrbmep/gkGc2wQrWzQJLSGGpd4zfX0x9RtXH1zqG46Velg1av66x NGlwkou3bkN7j7De4CZqbNDIfSS1f8n8BWN6092/UFTYF8KdQzr82VpOgMCFcgY7WbKv TWBiMdirPF2lEOKILaEH4/nSG8nnfpW6aYjFiUOnXxfIGB22jhBGNaSdW4Pe1/ZBiiaG pMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=SnkRbluJKNKCXqGjXdEAdbMv8i5e7kEhOYD7HeLmM00=; b=eLaxprg+Iuhj80RJZfE9xAVu2g1RWeWAaFqCAczTjK9wzxe9n+QCkq41bFscCNfADs iRxqkaFJa6JDc3kUwIf4eBgZGrBczrSxaDlF4vMlca/28NKzKZE8/CWpEDeGDx+e3x2Z b1MrcHiKL4/EKxDDcQNdTKIQYyk3bE5S1pqNJgXDvR7E3c1ZXAfacLSuzi/0gsOZT6FM FkmB9Ruk0fkv7eDQ2jUezjzptVNVnfyymstKgJHKxGrk5mj9jc1C7VbnAWP3UD+z1f5+ +UtFuyaIkivQqi3x37osIG0XvmRvO8YjCOuC8Rt/+guB49FRoBDIYDriR8TDN7Q+7pFx DpFg== X-Gm-Message-State: AIkVDXJac6KF+q4dZIqA8fPafgOHGhTM3XPwRV05TGYiIx4CA3Qz3TZ2A66VVZawJ992Mw== X-Received: by 10.28.109.156 with SMTP id b28mr8959321wmi.116.1482404192119; Thu, 22 Dec 2016 02:56:32 -0800 (PST) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id u78sm31553040wma.11.2016.12.22.02.56.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 02:56:31 -0800 (PST) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Thu, 22 Dec 2016 10:56:23 +0000 Message-Id: <20161222105625.10832-3-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161222105625.10832-1-chris@chris-wilson.co.uk> References: <20161222105625.10832-1-chris@chris-wilson.co.uk> Subject: [Intel-gfx] [PATCH 3/5] drm/i915: Eliminate superfluous i915_ggtt_view_rotated X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP It is only being used to clear a struct and set the type, after which it is overwritten. Since we no longer check the unset bits of the union, skipping the clear is permissible. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_gtt.c | 3 --- drivers/gpu/drm/i915/i915_gem_gtt.h | 1 - drivers/gpu/drm/i915/intel_display.c | 5 ++--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index d6fa8f740f23..c2a79eb6f40c 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -102,9 +102,6 @@ i915_get_ggtt_vma_pages(struct i915_vma *vma); const struct i915_ggtt_view i915_ggtt_view_normal = { .type = I915_GGTT_VIEW_NORMAL, }; -const struct i915_ggtt_view i915_ggtt_view_rotated = { - .type = I915_GGTT_VIEW_ROTATED, -}; int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv, int enable_ppgtt) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h index 25614feccdba..2af09cc63186 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h @@ -168,7 +168,6 @@ struct i915_ggtt_view { }; extern const struct i915_ggtt_view i915_ggtt_view_normal; -extern const struct i915_ggtt_view i915_ggtt_view_rotated; enum i915_cache_level; diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3608787730c4..f37b2c6e823a 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -2138,11 +2138,10 @@ intel_fill_fb_ggtt_view(struct i915_ggtt_view *view, const struct drm_framebuffer *fb, unsigned int rotation) { + view->type = I915_GGTT_VIEW_NORMAL; if (drm_rotation_90_or_270(rotation)) { - *view = i915_ggtt_view_rotated; + view->type = I915_GGTT_VIEW_ROTATED; view->rotated = to_intel_framebuffer(fb)->rot_info; - } else { - *view = i915_ggtt_view_normal; } }