From patchwork Sat Dec 31 12:06:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9492715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D61B62ABB for ; Sat, 31 Dec 2016 12:12:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4B34252D5 for ; Sat, 31 Dec 2016 12:12:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C8FA525D9E; Sat, 31 Dec 2016 12:12:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7B78F252D5 for ; Sat, 31 Dec 2016 12:12:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82686E2FB; Sat, 31 Dec 2016 12:12:23 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wj0-x241.google.com (mail-wj0-x241.google.com [IPv6:2a00:1450:400c:c01::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4385A6E2E5 for ; Sat, 31 Dec 2016 12:07:07 +0000 (UTC) Received: by mail-wj0-x241.google.com with SMTP id hb5so30259259wjc.2 for ; Sat, 31 Dec 2016 04:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=AJugLvZlOabx4WWvY9Z+GCVRTVy0Rno4c0usUM1mleI=; b=mLq/eOrA3DDYWK2pI5RoeKQrkbM9CJbbLYdNUxhH4qBiUtFoSU2Hm0Vvh4iKIJu4lK 0GYU7n7ip874E4MyOfNDOC2svdCMjE3UiflBfq0TDGEdHQkRf3W9sbihd2QUTExsZCen pWyD1BmdXoHB50EGpEo6dcJcwTNndnOr3b+0k/2WT9jesZhNBm0vx+binEh5Gimp/cy1 gSOpLMmrbCwWfvD2jyXyuF/6GJ3jRRJNdG6k+D0+3rJ/RaGpJArJvNmwdV7eSfjDV5XF nwf8fV5UFN+i5ZkwTXzarTSlZSug8VTGCsxyrZ5uaj9szlsuspIt7oS8r4L/2NHtGWjg soaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=AJugLvZlOabx4WWvY9Z+GCVRTVy0Rno4c0usUM1mleI=; b=F2cdY2Sd2gF18YTwOk9d80hmR620j5ghBfiilFRthoqzDkgwpPR0HUxXQhtOfMQRL0 xbdxrYDG1fJrDe4rdg2jWcIAXyLYBQ/qfpDNV+dY3yq6gT4p3MiPJB/uzCcSbNF3BtOd 6gRbmJQw0aj/trnfGcE15UWxGCs4HxMzlzRuZlcAhNrkRV+8X2XYHjf3YoFVLTpk30qQ n8GDMFEWv6odxgMiwGRz9z9nOQ0flI14BAm+lc1Y0SHsYSGJn6q1M3txra6tD6GWDRgW md19BJiiX+5Nk0YNhmrAJkZAHLYpYIsPjjEEzT4X/zunC4qgTdn2Aeve79dVC4uI8Hh4 hrJA== X-Gm-Message-State: AIkVDXKuqjTROi2HdKHJD5S4ech7fSzYvKpeSaVVs9R111sNyqeeYZ6Q7twZmjbtIAqdJA== X-Received: by 10.194.39.7 with SMTP id l7mr43026219wjk.182.1483186025525; Sat, 31 Dec 2016 04:07:05 -0800 (PST) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id c81sm74411987wmf.22.2016.12.31.04.07.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2016 04:07:05 -0800 (PST) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Sat, 31 Dec 2016 12:06:37 +0000 Message-Id: <20161231120702.21204-2-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20161231120702.21204-1-chris@chris-wilson.co.uk> References: <20161231120702.21204-1-chris@chris-wilson.co.uk> Subject: [Intel-gfx] [PATCH 01/26] drm/i915: Assert that we do create the deferred context X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP In order to convince static analyzers that the allocation function returns an error or sets ce->state, assert that it is set afterwards. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lrc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 227978820320..51ecb395551b 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -781,6 +781,7 @@ static int execlists_context_pin(struct intel_engine_cs *engine, if (ret) goto err; } + GEM_BUG_ON(!ce->state); flags = PIN_GLOBAL; if (ctx->ggtt_offset_bias)