From patchwork Wed Jan 18 12:18:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9523527 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 61A62601B7 for ; Wed, 18 Jan 2017 12:18:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5558428579 for ; Wed, 18 Jan 2017 12:18:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A45A28589; Wed, 18 Jan 2017 12:18:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 10A1828579 for ; Wed, 18 Jan 2017 12:18:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B40EB6E86F; Wed, 18 Jan 2017 12:18:18 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C83A6E869 for ; Wed, 18 Jan 2017 12:18:15 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id c85so3695289wmi.1 for ; Wed, 18 Jan 2017 04:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vI6kEVpQsSo/sYD5z3mcqtzjmeh34fGhlTCsewRGPQ4=; b=nZ4wqnijVY3+wxCRQvpkPQ+R4WLzUcEH1jMq2pe+H01CLZLtg6y6+eTJTlecq2hh1y P7O/kbrgDX3NuVE6yGiGizA6HA/h6Z261i23mW6LiIFgsq7FM1Z2QMNx4X1viWPRSEv3 Evy5LbXtrEzFqbu3DV7FYFeJx92DFbQOMwy3yIF2Kk4LCm9zks2DPsRJdrWtaCJBQZmq kEv5sP7dxuMTliOzFzWowMqVbQe/3XflKV+6WyVl6mLwXrM94efg3AfLPSvVjf2ke0pH xgkw16J/qVrDJ1rQxY0Y+l9MlebP+ZOU+LEo/eazU86XajCsn21f8LM/UmmH042vd8Ww FMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vI6kEVpQsSo/sYD5z3mcqtzjmeh34fGhlTCsewRGPQ4=; b=brO9FCIwxCkGl02yy4UXbpB7onmTh+Bq+1KVOM1AZrp1OUCBoes+M4EqFVfJC9DJyQ lEOPUNax8HCAO7Ha4uKDLMDRlL8INqmJ3c1HT30AdR0OVrqdS6GJ/C0ve4ro4muCvhmP nX41GnD3h4Op7EodyPbm1PvgnfDebI1bA5pReoefBJLwJV7xy/4mH7GuxIrfTlaxiwRk o5W9Iy9pvxPZ801rOV6o0nJFsAQkb5qvFOO7B4RGP4/xSR/Jz19EArDDoNtlwW3VGd+L SKu5Sz6Lm6FRHznU2ZHZOV2L2Sd/GHTJpv724uYn7eUgKBnEuz9zZIFtMP4vnMKLyNma fKPQ== X-Gm-Message-State: AIkVDXJ4SpZ0oecRoxswpSvJAbk0jsgsIKn8CEu9Ff6dfbE+EV1Jz3np2m8YvbE25EZJmw== X-Received: by 10.28.134.67 with SMTP id i64mr2514716wmd.5.1484741894086; Wed, 18 Jan 2017 04:18:14 -0800 (PST) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id f67sm44962526wmd.13.2017.01.18.04.18.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jan 2017 04:18:13 -0800 (PST) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Wed, 18 Jan 2017 12:18:08 +0000 Message-Id: <20170118121808.27869-2-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170118121808.27869-1-chris@chris-wilson.co.uk> References: <20170118121808.27869-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Fix W=1 warning for csr_load_work_fn() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP drivers/gpu/drm/i915/intel_csr.c: In function ‘csr_load_work_fn’: drivers/gpu/drm/i915/intel_csr.c:399:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable] Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_csr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 0085bc745f6a..9dcc434d3b74 100644 --- a/drivers/gpu/drm/i915/intel_csr.c +++ b/drivers/gpu/drm/i915/intel_csr.c @@ -396,13 +396,11 @@ static void csr_load_work_fn(struct work_struct *work) struct drm_i915_private *dev_priv; struct intel_csr *csr; const struct firmware *fw = NULL; - int ret; dev_priv = container_of(work, typeof(*dev_priv), csr.work); csr = &dev_priv->csr; - ret = request_firmware(&fw, dev_priv->csr.fw_path, - &dev_priv->drm.pdev->dev); + request_firmware(&fw, dev_priv->csr.fw_path, &dev_priv->drm.pdev->dev); if (fw) dev_priv->csr.dmc_payload = parse_csr_fw(dev_priv, fw);