diff mbox

[v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending

Message ID 20170124110009.28947-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson Jan. 24, 2017, 11 a.m. UTC 
To complement the check in execlists_elsp_ready(), also assert that we
don't submit the same context while it has a lite restore still pending.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/intel_lrc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Jan. 24, 2017, 4:06 p.m. UTC | #1 
On Tue, Jan 24, 2017 at 03:54:19PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending (rev3)
> URL   : https://patchwork.freedesktop.org/series/18474/
> State : success
> 
> == Summary ==
> 
> Series 18474v3 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/18474/revisions/3/mbox/
> 
> Test gem_exec_store:
>         Subgroup basic-blt:
>                 incomplete -> PASS       (fi-byt-j1900)

Thanks for the reviews, lots of patches for such an unnoticeable
improvement. Still looking for a miracle.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 32096d141d57..9dd612a2df16 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -375,6 +375,7 @@  static void execlists_submit_ports(struct intel_engine_cs *engine)
 		dev_priv->regs + i915_mmio_reg_offset(RING_ELSP(engine));
 	u64 desc[2];
 
+	GEM_BUG_ON(port[0].count > 1);
 	if (!port[0].count)
 		execlists_context_status_change(port[0].request,
 						INTEL_CONTEXT_SCHEDULE_IN);