diff mbox

[v2,2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

Message ID 20170130104458.2653-2-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson Jan. 30, 2017, 10:44 a.m. UTC 
Preproduction sdv are not supported beyond the release of production
hardware, and continued use is ill-advised. Mark the kernel as tainted
to reinforce the error.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Joonas Lahtinen Jan. 30, 2017, 12:31 p.m. UTC | #1 
On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> Preproduction sdv are not supported beyond the release of production
> hardware, and continued use is ill-advised. Mark the kernel as tainted
> to reinforce the error.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>

Correct use of taint flags. I think CPU_OUT_OF_SPEC could be more
correct flag, though?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
Chris Wilson Jan. 30, 2017, 1:25 p.m. UTC | #2 
On Mon, Jan 30, 2017 at 02:31:57PM +0200, Joonas Lahtinen wrote:
> On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> > Preproduction sdv are not supported beyond the release of production
> > hardware, and continued use is ill-advised. Mark the kernel as tainted
> > to reinforce the error.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> 
> Correct use of taint flags. I think CPU_OUT_OF_SPEC could be more
> correct flag, though?

No idea. I figure that our usage will be spotted one day and we will be
told which one to use, maybe even a new taint.

On x86 CPU_OUT_OF_SPEC is used if the user forces pae, sounds reasonable
but I wanted not to imply that this was a CPU issue itself, but relates
to out-of-spec GPU. MCE was broader and can be triggered by other
components failing.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index b55ad5199967..5ae5b190241c 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -787,9 +787,11 @@  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 	pre |= IS_HSW_EARLY_SDV(dev_priv);
 	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
 
-	if (pre)
+	if (pre) {
 		DRM_ERROR("This is a pre-production stepping. "
 			  "It may not be fully functional.\n");
+		add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
+	}
 }
 
 /**