| Message ID | 20170202091800.16593-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Op 02-02-17 om 10:18 schreef Chris Wilson: > These are meant to be fast and sensitive to new (and old) bugs... > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Petri Latvala <petri.latvala@intel.com> > --- > tests/intel-ci/fast-feedback.testlist | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > index 828bd3ff..a0c3f848 100644 > --- a/tests/intel-ci/fast-feedback.testlist > +++ b/tests/intel-ci/fast-feedback.testlist > @@ -249,4 +249,23 @@ igt@drv_module_reload@basic-reload > igt@drv_module_reload@basic-no-display > igt@drv_module_reload@basic-reload-inject > igt@drv_module_reload@basic-reload-final > +igt@drv_selftest@mock_sanitycheck > +igt@drv_selftest@mock_scatterlist > +igt@drv_selftest@mock_uncore > +igt@drv_selftest@mock_breadcrumbs > +igt@drv_selftest@mock_requests > +igt@drv_selftest@mock_objects > +igt@drv_selftest@mock_dmabuf > +igt@drv_selftest@mock_vma > +igt@drv_selftest@mock_evict > +igt@drv_selftest@mock_gtt > +igt@drv_selftest@live_sanitycheck > +igt@drv_selftest@live_uncore > +igt@drv_selftest@live_requests > +igt@drv_selftest@live_object > +igt@drv_selftest@live_dmabuf > +igt@drv_selftest@live_coherency > +igt@drv_selftest@live_gtt > +igt@drv_selftest@live_context > +igt@drv_selftest@live_hangcheck > igt@gvt_basic@invalid-placeholder-test Add basic somewhere in the test names?
On Thu, Feb 02, 2017 at 02:30:19PM +0100, Maarten Lankhorst wrote: > Op 02-02-17 om 10:18 schreef Chris Wilson: > > These are meant to be fast and sensitive to new (and old) bugs... > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Petri Latvala <petri.latvala@intel.com> > > --- > > tests/intel-ci/fast-feedback.testlist | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist > > index 828bd3ff..a0c3f848 100644 > > --- a/tests/intel-ci/fast-feedback.testlist > > +++ b/tests/intel-ci/fast-feedback.testlist > > @@ -249,4 +249,23 @@ igt@drv_module_reload@basic-reload > > igt@drv_module_reload@basic-no-display > > igt@drv_module_reload@basic-reload-inject > > igt@drv_module_reload@basic-reload-final > > +igt@drv_selftest@mock_sanitycheck > > +igt@drv_selftest@mock_scatterlist > > +igt@drv_selftest@mock_uncore > > +igt@drv_selftest@mock_breadcrumbs > > +igt@drv_selftest@mock_requests > > +igt@drv_selftest@mock_objects > > +igt@drv_selftest@mock_dmabuf > > +igt@drv_selftest@mock_vma > > +igt@drv_selftest@mock_evict > > +igt@drv_selftest@mock_gtt > > +igt@drv_selftest@live_sanitycheck > > +igt@drv_selftest@live_uncore > > +igt@drv_selftest@live_requests > > +igt@drv_selftest@live_object > > +igt@drv_selftest@live_dmabuf > > +igt@drv_selftest@live_coherency > > +igt@drv_selftest@live_gtt > > +igt@drv_selftest@live_context > > +igt@drv_selftest@live_hangcheck > > igt@gvt_basic@invalid-placeholder-test > > Add basic somewhere in the test names? Why? Does something still parse basic in the test name and add it to a test set? Shouldn't that now be pulling from these lists instead? -Chris
Op 02-02-17 om 14:44 schreef Chris Wilson: > On Thu, Feb 02, 2017 at 02:30:19PM +0100, Maarten Lankhorst wrote: >> Op 02-02-17 om 10:18 schreef Chris Wilson: >>> These are meant to be fast and sensitive to new (and old) bugs... >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Petri Latvala <petri.latvala@intel.com> >>> --- >>> tests/intel-ci/fast-feedback.testlist | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist >>> index 828bd3ff..a0c3f848 100644 >>> --- a/tests/intel-ci/fast-feedback.testlist >>> +++ b/tests/intel-ci/fast-feedback.testlist >>> @@ -249,4 +249,23 @@ igt@drv_module_reload@basic-reload >>> igt@drv_module_reload@basic-no-display >>> igt@drv_module_reload@basic-reload-inject >>> igt@drv_module_reload@basic-reload-final >>> +igt@drv_selftest@mock_sanitycheck >>> +igt@drv_selftest@mock_scatterlist >>> +igt@drv_selftest@mock_uncore >>> +igt@drv_selftest@mock_breadcrumbs >>> +igt@drv_selftest@mock_requests >>> +igt@drv_selftest@mock_objects >>> +igt@drv_selftest@mock_dmabuf >>> +igt@drv_selftest@mock_vma >>> +igt@drv_selftest@mock_evict >>> +igt@drv_selftest@mock_gtt >>> +igt@drv_selftest@live_sanitycheck >>> +igt@drv_selftest@live_uncore >>> +igt@drv_selftest@live_requests >>> +igt@drv_selftest@live_object >>> +igt@drv_selftest@live_dmabuf >>> +igt@drv_selftest@live_coherency >>> +igt@drv_selftest@live_gtt >>> +igt@drv_selftest@live_context >>> +igt@drv_selftest@live_hangcheck >>> igt@gvt_basic@invalid-placeholder-test >> Add basic somewhere in the test names? > Why? Does something still parse basic in the test name and add it to a > test set? Shouldn't that now be pulling from these lists instead? the fast feedback list is a subtest of all basic tests. scripts/run-tests.sh -t basic is supposed to run at least those. ~Maarten
Hi, > > > > Add basic somewhere in the test names? > > Why? Does something still parse basic in the test name and add it to a test No > set? Shouldn't that now be pulling from these lists instead? You are right, yes , we control only static list and addition to it through reviews, Petri, more to add? So we are not using -t basic anymore. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre Jani Saarinen Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
NAK on these with the current drv_selftest code. The subtest enumeration on IGT's side needs to contain these subtests even if the running kernel doesn't have selftests, or these particular subtests.
On Fri, Feb 17, 2017 at 01:50:06PM +0200, Petri Latvala wrote: > NAK on these with the current drv_selftest code. They are just slightly out of date. > The subtest enumeration on IGT's side needs to contain these subtests > even if the running kernel doesn't have selftests, or these particular > subtests. I thought you would have said, no way can we have these in BAT as the kernel likes to explode! They catch some rather critical bugs... -Chris
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 828bd3ff..a0c3f848 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -249,4 +249,23 @@ igt@drv_module_reload@basic-reload igt@drv_module_reload@basic-no-display igt@drv_module_reload@basic-reload-inject igt@drv_module_reload@basic-reload-final +igt@drv_selftest@mock_sanitycheck +igt@drv_selftest@mock_scatterlist +igt@drv_selftest@mock_uncore +igt@drv_selftest@mock_breadcrumbs +igt@drv_selftest@mock_requests +igt@drv_selftest@mock_objects +igt@drv_selftest@mock_dmabuf +igt@drv_selftest@mock_vma +igt@drv_selftest@mock_evict +igt@drv_selftest@mock_gtt +igt@drv_selftest@live_sanitycheck +igt@drv_selftest@live_uncore +igt@drv_selftest@live_requests +igt@drv_selftest@live_object +igt@drv_selftest@live_dmabuf +igt@drv_selftest@live_coherency +igt@drv_selftest@live_gtt +igt@drv_selftest@live_context +igt@drv_selftest@live_hangcheck igt@gvt_basic@invalid-placeholder-test
These are meant to be fast and sensitive to new (and old) bugs... Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Petri Latvala <petri.latvala@intel.com> --- tests/intel-ci/fast-feedback.testlist | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)